fix: #3074 restore SIGINT defaults for UnixLocal PTY children#3075
Merged
seratch merged 1 commit intoopenai:mainfrom May 2, 2026
Merged
fix: #3074 restore SIGINT defaults for UnixLocal PTY children#3075seratch merged 1 commit intoopenai:mainfrom
seratch merged 1 commit intoopenai:mainfrom
Conversation
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
seratch
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes a UnixLocal PTY bug where TTY-backed child processes can inherit an ignored
SIGINTdisposition from the parent process and fail to react to Ctrl-C.Test plan
uv run pytest -q tests/sandbox/test_unix_local.py::TestUnixLocalPty::test_pty_ctrl_c_interrupts_long_running_process tests/sandbox/test_unix_local.py::TestUnixLocalPty::test_pty_ctrl_c_interrupts_even_if_parent_ignores_sigintIssue number
Resolves #3074 for the SIGINT issue
Checks
make lintandmake format