test: cover on_handoff, on_tool_start, on_tool_end on RunHooks#3098
Merged
seratch merged 1 commit intoopenai:mainfrom May 4, 2026
Merged
Conversation
The existing test_run_hooks.py only asserted on_agent_start / on_agent_end / on_llm_start / on_llm_end. Tool and handoff invocation counts on run-level RunHooks were defined in RunHooksForTests but never exercised. Add two tests that fire tool calls + a handoff through Runner.run and Runner.run_streamed and assert the counts.
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds test coverage for on_handoff, on_tool_start, and on_tool_end on run-level RunHooks (both Runner.run and
Runner.run_streamed). These were defined in RunHooksForTests but never asserted.