test: add direct unit tests for _tool_identity helpers#3101
Merged
seratch merged 1 commit intoopenai:mainfrom May 4, 2026
Merged
test: add direct unit tests for _tool_identity helpers#3101seratch merged 1 commit intoopenai:mainfrom
seratch merged 1 commit intoopenai:mainfrom
Conversation
The _tool_identity module is imported across the runner, tracing, and tool-output trimmer code paths but had no direct test file. These helpers (tool_qualified_name, tool_trace_name, get_tool_call_*, get_function_tool_lookup_key, serialize/deserialize, the synthetic-namespace validator) are pure and easy to cover, including the bare / namespaced / deferred_top_level lookup-key shapes and the serialize/deserialize round-trip. Adds 29 focused unit tests.
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
seratch
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tool_identity module is imported across the runner, tracing, and tool-output trimmer code paths but
had no direct test file. These helpers (tool_qualified_name, tool_trace_name, get_tool_call*,
get_function_tool_lookup_key, serialize/deserialize, the synthetic-namespace validator) are pure and
easy to cover, including the bare / namespaced / deferred_top_level lookup-key shapes and the
serialize/deserialize round-trip. Adds 29 focused unit tests.