test: add direct unit tests for _mcp_tool_metadata helpers#3102
Merged
seratch merged 1 commit intoopenai:mainfrom May 4, 2026
Merged
test: add direct unit tests for _mcp_tool_metadata helpers#3102seratch merged 1 commit intoopenai:mainfrom
seratch merged 1 commit intoopenai:mainfrom
Conversation
The _mcp_tool_metadata module resolves MCP tool display metadata (title / description) from raw payloads or attribute-bearing objects and feeds hosted-MCP definitions into the model and traces, but had no direct test file. Adds 27 focused unit tests covering each helper's branches: explicit title preference, annotation fallback, description-vs-title precedence for the model-facing string, extract_mcp_tool_metadata, and collect_mcp_list_tools_metadata (including raw_item unwrapping, skipped shapes, and last-entry-wins).
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
seratch
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The _mcp_tool_metadata module resolves MCP tool display metadata (title / description) from raw payloads
or attribute-bearing objects and feeds hosted-MCP definitions into the model and traces, but had no
direct test file. Adds 27 focused unit tests covering each helper's branches: explicit title preference,
annotation fallback, description-vs-title precedence for the model-facing string,
extract_mcp_tool_metadata, and collect_mcp_list_tools_metadata (including raw_item unwrapping, skipped
shapes, and last-entry-wins).