fix: omit chat completions store by default#3105
Closed
Aphroq wants to merge 1 commit intoopenai:mainfrom
Closed
Conversation
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Member
|
Closing this due to #3103 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Chat Completions
storedefault handling soModelSettings(store=None)no longer sendsstore=Truefor the official OpenAI client.ModelSettings.storedocuments that Chat Completions is disabled when not specified, butChatCmplHelpers.get_store_param()previously opted official OpenAI clients intostore=True. This change returns the explicit setting as-is, preserving explicitstore=Trueandstore=Falsewhile omitting the parameter when unset.Test plan
uv run pytest tests/models/test_openai_chatcompletions.py -k 'store_param or fetch_response'bash .agents/skills/code-change-verification/scripts/run.shIssue number
Closes #3103
Checks
make lintandmake format