Skip to content

fix: omit chat completions store by default#3105

Closed
Aphroq wants to merge 1 commit intoopenai:mainfrom
Aphroq:fix/chat-completions-store-default
Closed

fix: omit chat completions store by default#3105
Aphroq wants to merge 1 commit intoopenai:mainfrom
Aphroq:fix/chat-completions-store-default

Conversation

@Aphroq
Copy link
Copy Markdown
Contributor

@Aphroq Aphroq commented May 4, 2026

Summary

Fixes Chat Completions store default handling so ModelSettings(store=None) no longer sends store=True for the official OpenAI client.

ModelSettings.store documents that Chat Completions is disabled when not specified, but ChatCmplHelpers.get_store_param() previously opted official OpenAI clients into store=True. This change returns the explicit setting as-is, preserving explicit store=True and store=False while omitting the parameter when unset.

Test plan

  • uv run pytest tests/models/test_openai_chatcompletions.py -k 'store_param or fetch_response'
  • bash .agents/skills/code-change-verification/scripts/run.sh

Issue number

Closes #3103

Checks

  • I've added new tests (if relevant)
  • I've added/updated the relevant documentation
  • I've run make lint and make format
  • I've made sure tests pass

@github-actions github-actions Bot added bug Something isn't working feature:chat-completions labels May 4, 2026
@seratch
Copy link
Copy Markdown
Member

seratch commented May 4, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@seratch
Copy link
Copy Markdown
Member

seratch commented May 4, 2026

Closing this due to #3103 (comment)

@seratch seratch closed this May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working feature:chat-completions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chat Completions defaults store=True despite ModelSettings docs

2 participants