fix: emit integer chat stream output indexes#3112
Closed
Aphroq wants to merge 1 commit intoopenai:mainfrom
Closed
Conversation
Contributor
Author
|
Closing as duplicate. #3108 now contains both Chat Completions streaming output_index fixes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Chat Completions streaming events so assistant message
output_indexvalues are emitted as integers instead of booleans when reasoning content precedes the message.The stream handler now uses a shared helper to compute the assistant message output index and the reasoning-content regression test asserts that text/message events use
1with exactinttype, notTrue.Test plan
uv run pytest tests/models/test_reasoning_content.py -k 'stream_response_yields_events_for_reasoning_content'bash .agents/skills/code-change-verification/scripts/run.shIssue number
Closes #3109
Checks
make lintandmake format