fix: use integer output_index instead of boolean in streaming handler#3119
Closed
kuishou68 wants to merge 2 commits intoopenai:mainfrom
Closed
fix: use integer output_index instead of boolean in streaming handler#3119kuishou68 wants to merge 2 commits intoopenai:mainfrom
kuishou68 wants to merge 2 commits intoopenai:mainfrom
Conversation
- Replace boolean expression (state.reasoning_content_index_and_output is not None) with explicit integer (1 if ... else 0) for output_index field - Fixes issue where streamed events could expose boolean True/False instead of integer 0/1 for output_index, breaking downstream JSON consumers - Affects 8 event types: ResponseOutputItemAddedEvent, ResponseContentPartAddedEvent, ResponseTextDeltaEvent, ResponseRefusalDeltaEvent Fixes openai#3109
- Line 422 was missing explicit 'is not None' comparison - This ensures output_index is always an integer (0 or 1), not a boolean - Consistent with all other output_index fixes in this PR
Member
|
Thanks for your interest here, but we're looking into more comprehensive solutions like #3108 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Chat Completions streaming handler uses a boolean expression for :
This produces / instead of integer /. While Python treats bool as int subclass, downstream JSON consumers and event snapshots can observe the wrong type.
Solution
Replace all 8 occurrences with explicit integer expression:
Testing
Verified no remaining boolean expressions for output_index in chatcmpl_stream_handler.py.
Fixes #3109