ci: use typecheck-only dependencies in CI#3369
Closed
seratch wants to merge 1 commit into
Closed
Conversation
Member
Author
|
This is not effective fro speeding up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the CI typecheck job to install a narrower dependency set before running mypy and pyright.
It adds a dedicated
typecheckdependency group, amake sync-typechecktarget for preparing that environment, and amake typecheck-no-synctarget so CI uses the already-synced environment instead of pulling the full dev group back in throughuv run. The regularmake syncandmake typecheckpaths remain available for local development and the broader verification workflow.In local cache-backed validation, the typecheck CI environment shrank from 194 installed packages with the full
make syncpath to 162 installed packages withmake sync-typecheck, removing 32 packages from the typecheck job setup. The newmake sync-typecheck+make typecheck-no-syncpath completed typechecking in 22 seconds locally after sync, while avoiding the extra automatic dependency sync thatuv runwould otherwise trigger. Exact wall-clock savings should be confirmed by the next GitHub Actions run because cold network/cache behavior dominates CI timing.