Skip to content

fix: guard non-positive session limit in AdvancedSQLiteSession.get_items #3416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rmotgi1227 wants to merge 1 commit into from
+9 −0
Closed

fix: guard non-positive session limit in AdvancedSQLiteSession.get_items #3416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/agents/extensions/memory/advanced_sqlite_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,9 @@ async def get_items(
"""
session_limit = resolve_session_limit(limit, self.session_settings)

if session_limit is not None and session_limit <= 0:
return []

if branch_id is None:
branch_id = self._current_branch_id

Expand Down
6 changes: 6 additions & 0 deletions tests/extensions/memory/test_advanced_sqlite_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1288,6 +1288,12 @@ async def test_get_items_explicit_limit_overrides_session_settings():
assert retrieved[0].get("content") == "Message 8"
assert retrieved[1].get("content") == "Message 9"

# Non-positive limits must return [] for parity with MongoDB/Redis/AsyncSQLite.
# SQLite treats LIMIT -1 as "no limit", so without an explicit guard a negative
# limit would incorrectly return all rows instead of an empty list.
assert await session.get_items(limit=0) == []
assert await session.get_items(limit=-1) == []

session.close()


Expand Down