ci: declare contents:read on create-releases and detect-breaking-changes#665
Open
arpitjain099 wants to merge 1 commit into
Open
Conversation
create-releases.yml runs stainless-api/trigger-release-please with STAINLESS_API_KEY (external secret), then optionally curls pkg.go.dev's proxy index. No GitHub API call uses the workflow GITHUB_TOKEN. detect-breaking-changes.yml runs scripts against the PR diff/base; no GitHub API write. Style matches the per-job permissions block in ci.yml (contents:read + id-token:write for trusted publishing). Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two workflows currently leave the workflow
GITHUB_TOKENscope implicit:.github/workflows/create-releases.yml-- runsstainless-api/trigger-release-please@v1.4.0withSTAINLESS_API_KEY(external secret) and, when a release is created, curlspkg.go.dev/fetch/...to warm the Go module proxy. Neither path uses the workflow'sGITHUB_TOKEN..github/workflows/detect-breaking-changes.yml-- runs scripts against the PR base SHA + HEAD to fail on breaking changes. No GitHub API write.This patch pins both to
permissions: contents: readat workflow scope, matching the per-job block inci.yml(contents: read+id-token: writefor trusted publishing).With explicit scope:
Token-Permissionscheck passes for both filesstainless-api/trigger-release-please,actions/setup-go,actions/checkout) is bounded to readNo behavioural change.