fix: track accumulator finished choice index#673
Open
MukundaKatta wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #428.\n\n## Summary\n- track finished accumulator state per streamed choice instead of only inspecting choice 0\n- return finished tool calls from the correct accumulated choice\n- expose the finished tool call choice through ChoiceIndex while preserving Index as the tool-call index\n- add a regression test for a tool call finishing on choice 1 while choice 0 continues streaming\n\n## Tests\n- go test . -run 'TestAccumulator(JustFinishedToolCallUsesChoiceIndex|NegativeToolCallIndex|EmptyToolCallsArray)'\n- go test ./... -run TestAccumulatorJustFinishedToolCallUsesChoiceIndex\n- git diff --check\n\nNote: I also tried the existing TestStreamingAccumulatorWithToolCalls, but it depends on the repo's localhost mock server setup and panicked on a nil mocked response in this environment before exercising this change.