Harden package installs with pnpm and CI updates#1838
Open
mcgrew-oai wants to merge 6 commits intomasterfrom
Open
Harden package installs with pnpm and CI updates#1838mcgrew-oai wants to merge 6 commits intomasterfrom
mcgrew-oai wants to merge 6 commits intomasterfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7d40a03040
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the repo's primary package manager from Yarn to pnpm and updates install paths in CI and ecosystem tests to use committed, repo-scoped package-manager configuration.
Changes in this PR:
examples/to pinned pnpm via Corepackpnpm-workspace.yamland commitpnpm-lock.yaml./scripts/bootstrapverify the pnpm hardening settings and always install with--frozen-lockfilecorepack pnpm.npmrcconfig, but run them with repo-pinnednpm@11.12.1so the npm hardening keys are actually respectedbun install --frozen-lockfilein CIexamples/package-lock artifactsWhy
To reduce package supply chain risk by making installs use committed, repo-scoped package-manager configuration in both local development and CI.
This moves the primary repo workflow onto pinned pnpm, makes bootstrap and CI use the same hardened install path, and keeps explicit config in the npm and Bun compatibility fixtures instead of relying on default package-manager behavior.
Testing
Ran locally:
./scripts/bootstrapcorepack pnpm buildcorepack pnpm lintenv -u OPENAI_API_KEY ./scripts/testbun install --frozen-lockfileinecosystem-tests/buncorepack pnpm tsn ecosystem-tests/cli.ts --retry=0 browser-direct-import ts-browser-webpack