24 release 2025 plantscan3d#25
Open
thomasarsouze wants to merge 14 commits into
Open
Conversation
10 tasks
This is needed for the CI to succeed
pradal
approved these changes
Apr 28, 2026
Contributor
pradal
left a comment
pradal
left a comment
There was a problem hiding this comment.
Great work!
- Some typos in the doc for section title
- Add pip in host section in conda/meta.yaml
- Some print may be replaced by logging module (but not mandatory...)
| @@ -0,0 +1,13 @@ | |||
| .. currentmodule:: openalea.plantscan3d | |||
|
|
|||
| livny reconstruction method | |||
| @@ -0,0 +1,12 @@ | |||
| .. currentmodule:: openalea.plantscan3d | |||
|
|
|||
| processmtg | |||
| @@ -0,0 +1,14 @@ | |||
| .. currentmodule:: openalea.plantscan3d | |||
|
|
|||
| processpoints | |||
| @@ -0,0 +1,13 @@ | |||
| .. currentmodule:: openalea.plantscan3d | |||
|
|
|||
| serial | |||
Contributor
There was a problem hiding this comment.
Serial -> Export points and MTG
| @@ -0,0 +1,13 @@ | |||
| .. currentmodule:: openalea.plantscan3d | |||
|
|
|||
| visualization | |||
| @@ -0,0 +1,13 @@ | |||
| .. currentmodule:: openalea.plantscan3d | |||
|
|
|||
| xu reconstruction method | |||
| print("Filter nodes", minelength) | ||
| shorts = detect_short_nodes(pointList, parents, minelength) | ||
| print('Percentage short node filtered :', 100 * len(shorts) / float(len(pointList)), '(', len(shorts), ')') | ||
| print( |
Contributor
|
@fredboudon Do you agreee? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A plantscan3d attempt for next openalea release. In addition to adapting the package to openalea guidelines, I've added documentation and exposed API. Still messy but I think it can be some nice addition to the package.
Please let me know what you think / add / remove @pradal and @fredboudon .