openapi-fetch: Request parameter in client methods was ignored#2332
openapi-fetch: Request parameter in client methods was ignored#2332sgrishchenko wants to merge 5 commits intoopenapi-ts:mainfrom
Request parameter in client methods was ignored#2332Conversation
✅ Deploy Preview for openapi-ts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: 771b03f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Sorry for the delay in reviewing. We’ve had some browser-specific bugs here when trying to work with Requests. Normally we’d ask to add tests to the browser tests as well, because believe-it-or-not, browsers do have some longstanding bugs in the Request API, and they differ from Node.js (see test suite for more details). However, in the time we’ve taken to review (which is 100% on us), we’re also putting openapi-fetch into maintenance mode to focus on the core libraries. So unfortunately I’ll have to close this PR, albeit tiny, as not acceptable in the last few releases before putting into maintenance mode. But we do appreciate the contribution, and hope you’ll contribute to the core library further! |
Changes
Small bag is fixed. Before these changes
Requestparameter in client methods was ignored.Also, it turned out that
Requestparameter was not added inRequestOptions, so I added the corresponding declaration.Also, it turned out that
Requestparameter was not added in API docs, so I tried to add it there.How to Review
I provided a unit test to demonstrate the problem, you can run it with and without my fix and check the results.
Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)