Skip to content

openapi-fetch: Request parameter in client methods was ignored#2332

Closed
sgrishchenko wants to merge 5 commits intoopenapi-ts:mainfrom
sgrishchenko:main
Closed

openapi-fetch: Request parameter in client methods was ignored#2332
sgrishchenko wants to merge 5 commits intoopenapi-ts:mainfrom
sgrishchenko:main

Conversation

@sgrishchenko
Copy link
Copy Markdown

@sgrishchenko sgrishchenko commented May 25, 2025

Changes

Small bag is fixed. Before these changes Request parameter in client methods was ignored.

Also, it turned out that Request parameter was not added in RequestOptions, so I added the corresponding declaration.

Also, it turned out that Request parameter was not added in API docs, so I tried to add it there.

How to Review

I provided a unit test to demonstrate the problem, you can run it with and without my fix and check the results.

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

@sgrishchenko sgrishchenko requested a review from a team as a code owner May 25, 2025 20:07
@sgrishchenko sgrishchenko requested a review from kerwanp May 25, 2025 20:07
@netlify
Copy link
Copy Markdown

netlify Bot commented May 25, 2025

Deploy Preview for openapi-ts ready!

Name Link
🔨 Latest commit 771b03f
🔍 Latest deploy log https://app.netlify.com/projects/openapi-ts/deploys/683380b90e72e80007d4cbd3
😎 Deploy Preview https://deploy-preview-2332--openapi-ts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 25, 2025

🦋 Changeset detected

Latest commit: 771b03f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
openapi-fetch Patch
openapi-react-query Patch
swr-openapi Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gzm0 gzm0 added the openapi-fetch Relevant to the openapi-fetch library label Oct 2, 2025
@drwpow
Copy link
Copy Markdown
Contributor

drwpow commented Feb 8, 2026

Sorry for the delay in reviewing. We’ve had some browser-specific bugs here when trying to work with Requests. Normally we’d ask to add tests to the browser tests as well, because believe-it-or-not, browsers do have some longstanding bugs in the Request API, and they differ from Node.js (see test suite for more details).

However, in the time we’ve taken to review (which is 100% on us), we’re also putting openapi-fetch into maintenance mode to focus on the core libraries. So unfortunately I’ll have to close this PR, albeit tiny, as not acceptable in the last few releases before putting into maintenance mode. But we do appreciate the contribution, and hope you’ll contribute to the core library further!

@drwpow drwpow closed this Feb 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

openapi-fetch Relevant to the openapi-fetch library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants