Skip to content

fix(openapi-fetch): reject excess request body and params properties #2679

Closed
F3n67u wants to merge 2 commits into
openapi-ts:mainfrom
F3n67u:fix-1769
Closed

fix(openapi-fetch): reject excess request body and params properties #2679
F3n67u wants to merge 2 commits into
openapi-ts:mainfrom
F3n67u:fix-1769

Conversation

@F3n67u

@F3n67u F3n67u commented Mar 13, 2026

Copy link
Copy Markdown

Changes

Fixes #1769 in openapi-fetch.

This changes openapi-fetch's request typing so excess properties are rejected consistently for body and params. It also moves the new regression coverage into dedicated *.test-d.ts type tests and adds the missing query array params to the shared common.yaml fixture used by params tests.

Checklist

  • Unit tests updated
  • docs/ updated (not needed)
  • pnpm run update:examples run (not applicable)

@netlify

netlify Bot commented Mar 13, 2026

Copy link
Copy Markdown

👷 Deploy request for openapi-ts pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 35b0924

@changeset-bot

changeset-bot Bot commented Mar 13, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 35b0924

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
openapi-fetch Patch
openapi-react-query Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@F3n67u F3n67u force-pushed the fix-1769 branch 3 times, most recently from 63eaec9 to 8898518 Compare March 14, 2026 19:59
@F3n67u F3n67u changed the title fix: tighten openapi-fetch excess property checks fix(openapi-fetch): reject excess request body and params properties Mar 14, 2026
@F3n67u F3n67u force-pushed the fix-1769 branch 2 times, most recently from 64b8ce4 to fd3bdb6 Compare March 14, 2026 20:01
@duncanbeevers

Copy link
Copy Markdown
Contributor

@F3n67u openapi-fetch is entering maintenance mode, and is unlikely to accept this change, particularly as it introduces new, non-optional behavior around payload / type validity.

@F3n67u

F3n67u commented Mar 16, 2026

Copy link
Copy Markdown
Author

@F3n67u openapi-fetch is entering maintenance mode, and is unlikely to accept this change, particularly as it introduces new, non-optional behavior around payload / type validity.

Thanks for the heads-up. I’ll close this MR

@F3n67u F3n67u closed this Mar 16, 2026
@F3n67u F3n67u deleted the fix-1769 branch March 16, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Undefined properties on body object are not flagged if required fields are filled in

2 participants