test: expand P0/P1 coverage for installer, brew, npm, and cli

Add deterministic command stubs for brew/npm and validate CLI pre-run config handling. Improves installer coverage and bumps total coverage to 27.8%.

Author: fullstackjam

internal/brew/brew_command_test.go

@@ -0,0 +1,91 @@
+package brew
+
+import (
+	"os"
+	"path/filepath"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func setupFakeBrew(t *testing.T, script string) {
+	t.Helper()
+	tmpDir := t.TempDir()
+	brewPath := filepath.Join(tmpDir, "brew")
+	require.NoError(t, os.WriteFile(brewPath, []byte(script), 0755))
+	originalPath := os.Getenv("PATH")
+	t.Setenv("PATH", tmpDir+string(os.PathListSeparator)+originalPath)
+}
+
+func TestGetInstalledPackages_ParsesOutput(t *testing.T) {
+	setupFakeBrew(t, "#!/bin/sh\n"+
+		"if [ \"$1\" = \"list\" ] && [ \"$2\" = \"--formula\" ]; then\n"+
+		"  echo git\n"+
+		"  echo curl\n"+
+		"  exit 0\n"+
+		"fi\n"+
+		"if [ \"$1\" = \"list\" ] && [ \"$2\" = \"--cask\" ]; then\n"+
+		"  echo firefox\n"+
+		"  exit 0\n"+
+		"fi\n"+
+		"exit 0\n")
+
+	formulae, casks, err := GetInstalledPackages()
+	require.NoError(t, err)
+	assert.True(t, formulae["git"])
+	assert.True(t, formulae["curl"])
+	assert.True(t, casks["firefox"])
+}
+
+func TestListOutdated_ParsesJSON(t *testing.T) {
+	setupFakeBrew(t, "#!/bin/sh\n"+
+		"if [ \"$1\" = \"outdated\" ] && [ \"$2\" = \"--json\" ]; then\n"+
+		"  cat <<'EOF'\n"+
+		"{\"formulae\":[{\"name\":\"git\",\"installed_versions\":[\"2.0\"],\"current_version\":\"2.1\"}],\"casks\":[{\"name\":\"firefox\",\"installed_versions\":[\"1.0\"],\"current_version\":\"2.0\"}]}\n"+
+		"EOF\n"+
+		"  exit 0\n"+
+		"fi\n"+
+		"exit 0\n")
+
+	outdated, err := ListOutdated()
+	require.NoError(t, err)
+	assert.Len(t, outdated, 2)
+	assert.Equal(t, "git", outdated[0].Name)
+	assert.Equal(t, "firefox (cask)", outdated[1].Name)
+}
+
+func TestDoctorDiagnose_Suggestions(t *testing.T) {
+	setupFakeBrew(t, "#!/bin/sh\n"+
+		"if [ \"$1\" = \"doctor\" ]; then\n"+
+		"  echo 'Warning: unbrewed header files were found'\n"+
+		"  echo 'Warning: broken symlinks detected'\n"+
+		"  exit 0\n"+
+		"fi\n"+
+		"exit 0\n")
+
+	suggestions, err := DoctorDiagnose()
+	require.NoError(t, err)
+	assert.Contains(t, suggestions, "Run: sudo rm -rf /usr/local/include")
+	assert.Contains(t, suggestions, "Run: brew cleanup --prune=all")
+}
+
+func TestUpdateAndCleanup_UsesBrew(t *testing.T) {
+	setupFakeBrew(t, "#!/bin/sh\n"+
+		"if [ \"$1\" = \"update\" ]; then\n"+
+		"  exit 0\n"+
+		"fi\n"+
+		"if [ \"$1\" = \"upgrade\" ]; then\n"+
+		"  exit 0\n"+
+		"fi\n"+
+		"if [ \"$1\" = \"cleanup\" ]; then\n"+
+		"  exit 0\n"+
+		"fi\n"+
+		"exit 0\n")
+
+	err := Update(false)
+	assert.NoError(t, err)
+
+	err = Cleanup()
+	assert.NoError(t, err)
+}

internal/brew/brew_test.go

@@ -1,6 +1,7 @@
 package brew
 
 import (
+	"strings"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -81,3 +82,133 @@ func TestParseBrewError(t *testing.T) {
 		})
 	}
 }
+
+func TestParseBrewError_LongErrorLine(t *testing.T) {
+	longLine := "Error: " + strings.Repeat("x", 100)
+	result := parseBrewError(longLine)
+	assert.LessOrEqual(t, len(result), 63)
+	assert.True(t, strings.HasSuffix(result, "..."))
+}
+
+func TestParseBrewError_EmptyOutput(t *testing.T) {
+	result := parseBrewError("")
+	assert.Equal(t, "unknown error", result)
+}
+
+func TestIsRetryableError(t *testing.T) {
+	tests := []struct {
+		name     string
+		errMsg   string
+		expected bool
+	}{
+		{"connection_timed_out", "connection timed out", true},
+		{"connection_refused", "connection refused", true},
+		{"no_internet", "no internet connection", true},
+		{"download_corrupted", "download corrupted", true},
+		{"already_running", "already running", true},
+		{"cannot_download", "Cannot download non-corrupt file", true},
+		{"signature_mismatch", "signature mismatch detected", true},
+		{"package_not_found", "package not found", false},
+		{"permission_denied", "permission denied", false},
+		{"disk_full", "disk full", false},
+		{"dependency_error", "dependency error", false},
+		{"unknown_error", "unknown error", false},
+		{"empty_string", "", false},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			result := isRetryableError(tt.errMsg)
+			assert.Equal(t, tt.expected, result)
+		})
+	}
+}
+
+func TestInstall_EmptyPackages(t *testing.T) {
+	err := Install([]string{}, false)
+	assert.NoError(t, err)
+}
+
+func TestInstall_DryRun(t *testing.T) {
+	err := Install([]string{"git", "curl", "jq"}, true)
+	assert.NoError(t, err)
+}
+
+func TestInstallCask_EmptyPackages(t *testing.T) {
+	err := InstallCask([]string{}, false)
+	assert.NoError(t, err)
+}
+
+func TestInstallCask_DryRun(t *testing.T) {
+	err := InstallCask([]string{"firefox", "visual-studio-code"}, true)
+	assert.NoError(t, err)
+}
+
+func TestInstallTaps_EmptyTaps(t *testing.T) {
+	err := InstallTaps([]string{}, false)
+	assert.NoError(t, err)
+}
+
+func TestInstallTaps_DryRun(t *testing.T) {
+	err := InstallTaps([]string{"homebrew/cask-fonts", "hashicorp/tap"}, true)
+	assert.NoError(t, err)
+}
+
+func TestInstallWithProgress_EmptyPackages(t *testing.T) {
+	err := InstallWithProgress([]string{}, []string{}, false)
+	assert.NoError(t, err)
+}
+
+func TestInstallWithProgress_DryRun(t *testing.T) {
+	err := InstallWithProgress([]string{"git", "curl"}, []string{"firefox"}, true)
+	assert.NoError(t, err)
+}
+
+func TestUpdate_DryRun(t *testing.T) {
+	err := Update(true)
+	assert.NoError(t, err)
+}
+
+func TestCheckDiskSpace(t *testing.T) {
+	gb, err := CheckDiskSpace()
+	assert.NoError(t, err)
+	assert.Greater(t, gb, 0.0)
+}
+
+func TestOutdatedPackageStruct(t *testing.T) {
+	pkg := OutdatedPackage{
+		Name:    "git",
+		Current: "2.40.0",
+		Latest:  "2.42.0",
+	}
+	assert.Equal(t, "git", pkg.Name)
+	assert.Equal(t, "2.40.0", pkg.Current)
+	assert.Equal(t, "2.42.0", pkg.Latest)
+}
+
+func TestHandleFailedJobs_Empty(t *testing.T) {
+	handleFailedJobs(nil)
+	handleFailedJobs([]failedJob{})
+}
+
+func TestHandleFailedJobs_WithFailures(t *testing.T) {
+	failed := []failedJob{
+		{installJob: installJob{name: "pkg1", isCask: false}, errMsg: "not found"},
+		{installJob: installJob{name: "pkg2", isCask: true}, errMsg: ""},
+	}
+	handleFailedJobs(failed)
+}
+
+func TestRunParallelInstallWithProgress_EmptyPkgs(t *testing.T) {
+	result := runParallelInstallWithProgress(nil, nil)
+	assert.Nil(t, result)
+}
+
+func TestIsInstalled(t *testing.T) {
+	result := IsInstalled()
+	assert.IsType(t, true, result)
+}
+
+func TestMaxWorkersConstant(t *testing.T) {
+	assert.Equal(t, 1, maxWorkers)
+}

internal/cli/root_test.go

@@ -0,0 +1,60 @@
+package cli
+
+import (
+	"encoding/json"
+	"net/http"
+	"net/http/httptest"
+	"testing"
+
+	"github.com/openbootdotdev/openboot/internal/config"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestPersistentPreRunE_SilentEnvOverrides(t *testing.T) {
+	oldCfg := cfg
+	cfg = &config.Config{Silent: true}
+	t.Cleanup(func() { cfg = oldCfg })
+
+	t.Setenv("OPENBOOT_GIT_NAME", "Test User")
+	t.Setenv("OPENBOOT_GIT_EMAIL", "test@example.com")
+	t.Setenv("OPENBOOT_PRESET", "developer")
+
+	err := rootCmd.PersistentPreRunE(rootCmd, []string{})
+	require.NoError(t, err)
+	assert.Equal(t, "Test User", cfg.GitName)
+	assert.Equal(t, "test@example.com", cfg.GitEmail)
+	assert.Equal(t, "developer", cfg.Preset)
+}
+
+func TestPersistentPreRunE_UserFetchesRemoteConfig(t *testing.T) {
+	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		assert.Equal(t, "/testuser/default/config", r.URL.Path)
+		response := config.RemoteConfig{
+			Username: "testuser",
+			Slug:     "default",
+			Preset:   "developer",
+			Packages: []string{"git"},
+			Casks:    []string{"firefox"},
+			Npm:      []string{"typescript"},
+		}
+		w.Header().Set("Content-Type", "application/json")
+		require.NoError(t, json.NewEncoder(w).Encode(response))
+	}))
+	defer server.Close()
+
+	oldCfg := cfg
+	cfg = &config.Config{}
+	t.Cleanup(func() { cfg = oldCfg })
+
+	t.Setenv("OPENBOOT_USER", "testuser")
+	t.Setenv("OPENBOOT_API_URL", server.URL)
+	t.Setenv("HOME", t.TempDir())
+
+	err := rootCmd.PersistentPreRunE(rootCmd, []string{})
+	require.NoError(t, err)
+	require.NotNil(t, cfg.RemoteConfig)
+	assert.Equal(t, "testuser", cfg.User)
+	assert.Equal(t, "developer", cfg.Preset)
+	assert.Equal(t, "developer", cfg.RemoteConfig.Preset)
+}