test(e2e): move all e2e tests into Tart VMs

All non-VM e2e tests were running on the developer's local machine,
reading local brew state and running openboot doctor/snapshot/diff/clean
against the host system.

- Change build tag from `e2e` → `e2e && vm` on all 5 files
- Replace exec.Command(binary) with vmRunDevBinary(t, vm, bin, args)
- Each test now boots a Tart VM, installs Homebrew, copies the binary
- Remove tests already covered by vm_commands_test.go (version, help,
  doctor, unknown command/flag, snapshot, logout duplicates)
- `go build -tags="e2e"` now matches no packages (nothing runs locally)
- `go build -tags="e2e,vm"` compiles cleanly

Author: fullstackjam

test/e2e/clean_e2e_test.go

@@ -1,90 +1,98 @@
-//go:build e2e
+//go:build e2e && vm
 
 package e2e
 
 import (
-	"os"
-	"os/exec"
 	"strings"
 	"testing"
 
 	"github.com/openbootdotdev/openboot/testutil"
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 )
 
 func TestE2E_Clean_DryRun_FromFile(t *testing.T) {
-	binary := testutil.BuildTestBinary(t)
-	tmpDir := t.TempDir()
+	if testing.Short() {
+		t.Skip("skipping VM test in short mode")
+	}
+
+	vm := testutil.NewTartVM(t)
+	vmInstallHomebrew(t, vm)
+	bin := vmCopyDevBinary(t, vm)
 
 	// Create a snapshot with a small set of packages — system will have "extra"
-	snapshotPath := writeTestSnapshot(t, tmpDir, []string{"git"}, []string{}, []string{})
+	snapshotPath := "/tmp/clean-test-snapshot.json"
+	vmWriteTestSnapshot(t, vm, snapshotPath, []string{"git"}, []string{}, []string{})
 
 	// Capture installed packages before
-	beforePkgs, err := testutil.GetInstalledBrewPackages()
-	if err != nil {
-		t.Skipf("cannot list brew packages: %v", err)
-	}
-
-	cmd := exec.Command(binary, "clean", "--from", snapshotPath, "--dry-run")
-	output, err := cmd.CombinedOutput()
-	outStr := string(output)
+	beforePkgs := vmBrewList(t, vm)
 
-	assert.NoError(t, err, "clean --dry-run should succeed, output: %s", outStr)
+	output, err := vmRunDevBinary(t, vm, bin, "clean --from "+snapshotPath+" --dry-run")
+	assert.NoError(t, err, "clean --dry-run should succeed, output: %s", output)
 	assert.True(t,
-		strings.Contains(outStr, "DRY-RUN") || strings.Contains(outStr, "dry run") || strings.Contains(outStr, "Dry run"),
-		"output should mention dry-run mode, got: %s", outStr)
+		strings.Contains(output, "DRY-RUN") || strings.Contains(output, "dry run") || strings.Contains(output, "Dry run"),
+		"output should mention dry-run mode, got: %s", output)
 
 	// Verify nothing was actually removed
-	afterPkgs, err := testutil.GetInstalledBrewPackages()
-	if err != nil {
-		t.Skipf("cannot list brew packages: %v", err)
-	}
+	afterPkgs := vmBrewList(t, vm)
 	assert.Equal(t, len(beforePkgs), len(afterPkgs),
 		"dry-run should not remove any packages (before=%d, after=%d)", len(beforePkgs), len(afterPkgs))
 }
 
 func TestE2E_Clean_MissingFile(t *testing.T) {
-	binary := testutil.BuildTestBinary(t)
+	if testing.Short() {
+		t.Skip("skipping VM test in short mode")
+	}
 
-	cmd := exec.Command(binary, "clean", "--from", "/tmp/nonexistent-snapshot-99999.json")
-	output, err := cmd.CombinedOutput()
-	outStr := string(output)
+	vm := testutil.NewTartVM(t)
+	vmInstallHomebrew(t, vm)
+	bin := vmCopyDevBinary(t, vm)
 
+	output, err := vmRunDevBinary(t, vm, bin, "clean --from /tmp/nonexistent-snapshot-99999.json")
 	assert.Error(t, err, "clean with missing file should fail")
 	assert.True(t,
-		strings.Contains(outStr, "not found") || strings.Contains(outStr, "no such file") || strings.Contains(outStr, "snapshot"),
-		"error should mention file issue, got: %s", outStr)
+		strings.Contains(output, "not found") || strings.Contains(output, "no such file") || strings.Contains(output, "snapshot"),
+		"error should mention file issue, got: %s", output)
 }
 
 func TestE2E_Clean_NoLocalSnapshot(t *testing.T) {
-	binary := testutil.BuildTestBinary(t)
+	if testing.Short() {
+		t.Skip("skipping VM test in short mode")
+	}
 
-	// Run clean without flags — tries local snapshot
-	cmd := exec.Command(binary, "clean")
-	// Set HOME to a temp dir so no local snapshot exists
-	tmpHome := t.TempDir()
-	cmd.Env = append(os.Environ(), "HOME="+tmpHome)
+	vm := testutil.NewTartVM(t)
+	vmInstallHomebrew(t, vm)
+	bin := vmCopyDevBinary(t, vm)
 
-	output, err := cmd.CombinedOutput()
-	outStr := string(output)
+	// Run clean without flags — tries local snapshot which won't exist in fresh VM
+	// Use a temp HOME dir in the VM with no snapshot
+	_, err := vm.Run("mkdir -p /tmp/clean-no-snapshot-home")
+	require.NoError(t, err)
 
+	output, err := vm.RunWithEnv(
+		map[string]string{"PATH": brewPath, "HOME": "/tmp/clean-no-snapshot-home"},
+		bin+" clean",
+	)
 	if err != nil {
 		assert.True(t,
-			strings.Contains(outStr, "snapshot") || strings.Contains(outStr, "--from") || strings.Contains(outStr, "--user"),
-			"error should guide user, got: %s", outStr)
+			strings.Contains(output, "snapshot") || strings.Contains(output, "--from") || strings.Contains(output, "--user"),
+			"error should guide user, got: %s", output)
 	}
 }
 
 func TestE2E_Clean_HelpFlag(t *testing.T) {
-	binary := testutil.BuildTestBinary(t)
+	if testing.Short() {
+		t.Skip("skipping VM test in short mode")
+	}
 
-	cmd := exec.Command(binary, "clean", "--help")
-	output, err := cmd.CombinedOutput()
-	outStr := string(output)
+	vm := testutil.NewTartVM(t)
+	vmInstallHomebrew(t, vm)
+	bin := vmCopyDevBinary(t, vm)
 
+	output, err := vmRunDevBinary(t, vm, bin, "clean --help")
 	assert.NoError(t, err, "clean --help should succeed")
-	assert.Contains(t, outStr, "clean")
-	assert.Contains(t, outStr, "--from")
-	assert.Contains(t, outStr, "--user")
-	assert.Contains(t, outStr, "--dry-run")
+	assert.Contains(t, output, "clean")
+	assert.Contains(t, output, "--from")
+	assert.Contains(t, output, "--user")
+	assert.Contains(t, output, "--dry-run")
 }