Fix issues when copying hits in native client

Closes #1082

Author: openbullet

OpenBullet2.Native.Tests/ListBoxExtensionsTests.cs

@@ -0,0 +1,65 @@
+using OpenBullet2.Native.Extensions;
+using System.Collections.ObjectModel;
+using System.Windows.Controls;
+
+namespace OpenBullet2.Native.Tests;
+
+[Collection("WPF")]
+public sealed class ListBoxExtensionsTests(WpfAppFixture fixture)
+{
+    [Fact]
+    public async Task GetSelectedItemsInDisplayOrder_ReturnsItemsInVisibleOrder()
+    {
+        await fixture.InvokeAsync(_ =>
+        {
+            var items = new[]
+            {
+                new TestItem("first"),
+                new TestItem("second"),
+                new TestItem("third")
+            };
+
+            var listView = new ListView
+            {
+                SelectionMode = SelectionMode.Extended,
+                ItemsSource = items
+            };
+
+            listView.SelectedItems.Add(items[2]);
+            listView.SelectedItems.Add(items[0]);
+
+            var selected = listView.GetSelectedItemsInDisplayOrder<TestItem>();
+
+            Assert.Equal([items[0], items[2]], selected);
+        });
+    }
+
+    [Fact]
+    public async Task GetSelectedItemsInDisplayOrder_ExcludesItemsNoLongerInTheList()
+    {
+        await fixture.InvokeAsync(_ =>
+        {
+            var items = new ObservableCollection<TestItem>
+            {
+                new("first"),
+                new("second"),
+                new("third")
+            };
+
+            var listView = new ListView
+            {
+                SelectionMode = SelectionMode.Extended,
+                ItemsSource = items
+            };
+
+            listView.SelectedItems.Add(items[1]);
+            items.RemoveAt(1);
+
+            var selected = listView.GetSelectedItemsInDisplayOrder<TestItem>();
+
+            Assert.Empty(selected);
+        });
+    }
+
+    private sealed record TestItem(string Value);
+}

OpenBullet2.Native/Extensions/ListBoxExtensions.cs

@@ -0,0 +1,24 @@
+using System.Collections.Generic;
+using System.Linq;
+using System.Windows.Controls;
+
+namespace OpenBullet2.Native.Extensions;
+
+public static class ListBoxExtensions
+{
+    public static List<T> GetSelectedItemsInDisplayOrder<T>(this ListBox listBox)
+    {
+        if (listBox.SelectedItems.Count == 0)
+        {
+            return [];
+        }
+
+        var selectedItems = listBox.SelectedItems.Cast<object>().ToHashSet();
+
+        return listBox.Items
+            .Cast<object>()
+            .Where(selectedItems.Contains)
+            .Cast<T>()
+            .ToList();
+    }
+}

OpenBullet2.Native/Views/Pages/Hits.xaml.cs

@@ -35,10 +35,7 @@ public partial class Hits : Page
     private GridViewColumnHeader? listViewSortCol;
     private SortAdorner? listViewSortAdorner;
 
-    private IEnumerable<HitEntity> SelectedHits => hitsListView.SelectedItems
-        .Cast<HitEntity>()
-        .OrderBy(hit => hitsListView.Items.IndexOf(hit))
-        .ToList();
+    private IEnumerable<HitEntity> SelectedHits => hitsListView.GetSelectedItemsInDisplayOrder<HitEntity>();
 
     private readonly Func<HitEntity, string> captureMapping = new(hit => $"{hit.Data} | {hit.CapturedData}");
     private readonly Func<HitEntity, string> fullMapping = new(hit =>

OpenBullet2.Native/Views/Pages/MultiRunJobViewer.xaml.cs

@@ -31,7 +31,7 @@ public partial class MultiRunJobViewer : Page
     private GridViewColumnHeader? listViewSortCol;
     private SortAdorner? listViewSortAdorner;
 
-    private IEnumerable<HitViewModel> SelectedHits => hitsListView.SelectedItems.Cast<HitViewModel>().ToList();
+    private IEnumerable<HitViewModel> SelectedHits => hitsListView.GetSelectedItemsInDisplayOrder<HitViewModel>();
     private MultiRunJobViewerViewModel ViewModel => vm
         ?? throw new InvalidOperationException("The job viewer has not been bound yet");