Add ability to disable dangerous config warning from OB settings

Closes #888

Author: openbullet

OpenBullet2.Core/Models/Settings/GeneralSettings.cs

@@ -87,6 +87,12 @@ public class GeneralSettings
     /// </summary>
     public bool WarnConfigNotSaved { get; set; } = true;
 
+    /// <summary>
+    /// Whether to output a warning when selecting a config that might contain
+    /// custom C# code or external program calls.
+    /// </summary>
+    public bool WarnDangerousConfig { get; set; } = true;
+
     /// <summary>
     /// The default author to use when creating new configs.
     /// </summary>

OpenBullet2.Native/ViewModels/OBSettingsViewModel.cs

@@ -54,6 +54,16 @@ public bool WarnConfigNotSaved
         }
     }
 
+    public bool WarnDangerousConfig
+    {
+        get => General.WarnDangerousConfig;
+        set
+        {
+            General.WarnDangerousConfig = value;
+            OnPropertyChanged();
+        }
+    }
+
     public string DefaultAuthor
     {
         get => General.DefaultAuthor;

OpenBullet2.Native/Views/Dialogs/MultiRunJobOptionsDialog.xaml.cs

@@ -34,24 +34,28 @@ namespace OpenBullet2.Native.Views.Dialogs;
 public partial class MultiRunJobOptionsDialog : Page
 {
     private readonly IUiFactory uiFactory;
+    private readonly OpenBulletSettingsService obSettingsService;
     private readonly Func<JobOptions, Task>? onAccept;
     private readonly MultiRunJobOptionsViewModel vm;
 
     public MultiRunJobOptionsDialog(
         IUiFactory uiFactory,
+        OpenBulletSettingsService obSettingsService,
         MultiRunJobOptionsViewModel vm,
         Func<JobOptions, Task>? onAccept)
-        : this(uiFactory, vm, null, onAccept)
+        : this(uiFactory, obSettingsService, vm, null, onAccept)
     {
     }
 
     public MultiRunJobOptionsDialog(
         IUiFactory uiFactory,
+        OpenBulletSettingsService obSettingsService,
         MultiRunJobOptionsViewModel vm,
         MultiRunJobOptions? options,
         Func<JobOptions, Task>? onAccept)
     {
         this.uiFactory = uiFactory;
+        this.obSettingsService = obSettingsService;
         this.onAccept = onAccept;
         this.vm = vm;
         vm.Initialize(options);
@@ -127,7 +131,9 @@ private async void Accept(object sender, RoutedEventArgs e)
                 return;
             }
 
-            if (vm.SelectedConfig is not null && vm.SelectedConfig.HasCSharpCode())
+            if (obSettingsService.Settings.GeneralSettings.WarnDangerousConfig
+                && vm.SelectedConfig is not null
+                && vm.SelectedConfig.HasCSharpCode())
             {
                 Alert.Warning("Potentially dangerous config", "The Config you selected might have some C# code in it" +
                     " (or blocks that call external programs). Although C# can be helpful for config makers who want to" +

OpenBullet2.Native/Views/Pages/OBSettings.xaml

@@ -43,6 +43,10 @@
                           IsChecked="{Binding WarnConfigNotSaved}" 
                           VerticalContentAlignment="Center"
                           Margin="5 10 0 0"/>
+                <CheckBox Content="View warning when selecting a potentially dangerous config" 
+                          IsChecked="{Binding WarnDangerousConfig}" 
+                          VerticalContentAlignment="Center"
+                          Margin="5 10 0 0"/>
                 <StackPanel Orientation="Horizontal" Margin="0 10 0 0">
                     <Label>Default author for new configs</Label>
                     <TextBox Text="{Binding DefaultAuthor}" 

OpenBullet2.Web.Tests/Integration/SettingsIntegrationTests.cs

@@ -150,6 +150,7 @@ public async Task GetSettings_Admin_Success()
         using var client = Factory.CreateClient();
         var openBulletSettings = GetRequiredService<OpenBulletSettingsService>();
         openBulletSettings.Settings.GeneralSettings.DefaultAuthor = "test";
+        openBulletSettings.Settings.GeneralSettings.WarnDangerousConfig = false;
         await openBulletSettings.SaveAsync();
 
         // Act
@@ -160,6 +161,7 @@ public async Task GetSettings_Admin_Success()
         Assert.True(result.IsSuccess);
         Assert.NotNull(result.Value);
         Assert.Equal("test", result.Value.GeneralSettings.DefaultAuthor);
+        Assert.False(result.Value.GeneralSettings.WarnDangerousConfig);
     }
 
     [Fact]
@@ -207,11 +209,16 @@ public async Task UpdateSettings_Admin_Success()
         using var client = Factory.CreateClient();
         var openBulletSettings = GetRequiredService<OpenBulletSettingsService>();
         openBulletSettings.Settings.GeneralSettings.DefaultAuthor = "test";
+        openBulletSettings.Settings.GeneralSettings.WarnDangerousConfig = true;
         await openBulletSettings.SaveAsync();
 
         var newSettings = new OpenBulletSettingsDto
         {
-            GeneralSettings = new OBGeneralSettingsDto { DefaultAuthor = "test2" }
+            GeneralSettings = new OBGeneralSettingsDto
+            {
+                DefaultAuthor = "test2",
+                WarnDangerousConfig = false
+            }
         };
 
         // Act
@@ -221,7 +228,9 @@ public async Task UpdateSettings_Admin_Success()
         // Assert
         Assert.True(result.IsSuccess);
         Assert.Equal("test2", result.Value.GeneralSettings.DefaultAuthor);
+        Assert.False(result.Value.GeneralSettings.WarnDangerousConfig);
         Assert.Equal("test2", openBulletSettings.Settings.GeneralSettings.DefaultAuthor);
+        Assert.False(openBulletSettings.Settings.GeneralSettings.WarnDangerousConfig);
     }
 
     [Fact]

OpenBullet2.Web/Dtos/Settings/OBGeneralSettingsDto.cs

@@ -28,6 +28,12 @@ public class OBGeneralSettingsDto
     /// </summary>
     public bool WarnConfigNotSaved { get; set; } = true;
 
+    /// <summary>
+    /// Whether to output a warning when selecting a config that might contain
+    /// custom C# code or external program calls.
+    /// </summary>
+    public bool WarnDangerousConfig { get; set; } = true;
+
     /// <summary>
     /// The default author to use when creating new configs.
     /// </summary>

openbullet2-web-client/src/app/main/components/configs/configs.component.ts

@@ -171,7 +171,7 @@ export class ConfigsComponent implements OnInit {
         summary: 'Selected',
         detail: `Selected config ${resp.metadata.name}`,
       });
-      if (config.dangerous) {
+      if (config.dangerous && this.obSettings?.generalSettings.warnDangerousConfig !== false) {
         this.messageService.add({
           key: 'br',
           severity: 'warn',

openbullet2-web-client/src/app/main/components/jobs/edit-multi-run-job/edit-multi-run-job.component.ts

@@ -33,6 +33,7 @@ import { DeactivatableComponent } from 'src/app/shared/guards/can-deactivate-for
 import { parseTimeSpan } from 'src/app/shared/utils/dates';
 import { FieldValidity } from 'src/app/shared/utils/forms';
 import { TimeSpan } from 'src/app/shared/utils/timespan';
+import { OBSettingsDto } from 'src/app/main/dtos/settings/ob-settings.dto';
 import { AddWordlistComponent } from '../../wordlists/add-wordlist/add-wordlist.component';
 import { UploadWordlistComponent } from '../../wordlists/upload-wordlist/upload-wordlist.component';
 import { SelectConfigComponent } from '../select-config/select-config.component';
@@ -102,6 +103,7 @@ export class EditMultiRunJobComponent implements DeactivatableComponent {
   mode: EditMode = EditMode.Edit;
   jobId: number | null = null;
   options: MultiRunJobOptionsDto | null = null;
+  obSettings: OBSettingsDto | null = null;
   proxyGroups: ProxyGroupDto[] | null = null;
   wordlistTypes: string[] = [];
   botLimit = 200;
@@ -181,6 +183,10 @@ export class EditMultiRunJobComponent implements DeactivatableComponent {
       this.dataPoolWordlistType = settings.wordlistTypes[0].name;
     });
 
+    settingsService.getSettings().subscribe((settings) => {
+      this.obSettings = settings;
+    });
+
     settingsService.getSystemSettings().subscribe((settings) => {
       this.botLimit = settings.botLimit;
     });
@@ -444,7 +450,7 @@ export class EditMultiRunJobComponent implements DeactivatableComponent {
   }
 
   selectConfig(config: ConfigInfoDto) {
-    if (config.dangerous) {
+    if (config.dangerous && this.obSettings?.generalSettings.warnDangerousConfig !== false) {
       this.messageService.add({
         key: 'br',
         severity: 'warn',

openbullet2-web-client/src/app/main/components/ob-settings/ob-settings.component.html

@@ -61,6 +61,15 @@ <h3>General</h3>
                 label="Show a warning when the currently loaded config was not saved and another one is loaded" />
         </div>
     </div>
+    <div class="row my-3">
+        <div class="col-12">
+            <p-checkbox
+                (onChange)="touched = true" ngDefaultControl
+                [(ngModel)]="settings.generalSettings.warnDangerousConfig"
+                [binary]="true" inputId="warnDangerousConfig"
+                label="Show a warning when selecting a potentially dangerous config" />
+        </div>
+    </div>
     <div class="row my-3">
         <div class="col-12">
             <span class="mr-2">Default author on newly created configs</span>

openbullet2-web-client/src/app/main/dtos/settings/ob-settings.dto.ts

@@ -24,6 +24,7 @@ export interface GeneralOBSettings {
   configSectionOnLoad: ConfigSection;
   autoSetRecommendedBots: boolean;
   warnConfigNotSaved: boolean;
+  warnDangerousConfig: boolean;
   defaultAuthor: string;
   enableJobLogging: boolean;
   logBufferSize: number;