refactor: stop persisting inline HTML for status change activity notes#713
Conversation
1b57f6d to
f4fc377
Compare
f4fc377 to
319ad64
Compare
RussH
left a comment
There was a problem hiding this comment.
Thank you for the PR — this looks good (as always!), but on a more detailed review I found a couple of niggles I’d like fixed before merging:
The new highlighting helper is only applied in some activity views (candidates/Show.tpl, contacts/Show.tpl, activity/Search.tpl), but not all of them. For example, companies/Show.tpl still renders notes without the helper, so after the schema cleanup the orange status emphasis will disappear there.
There may be a double-escaping issue. In CandidatesUI.php the status change note is already passed through htmlspecialchars() before storage, and the new helper escapes again on output. That could display entities incorrectly for statuses containing special characters?
Please take a look and let me know.
|
I think we should mark this PR as draft for now. I just found out that #702 is not working properly for Candidate Activities and still has problems with HTML entities, so I think we should fix this first before we continue work on this PR. |
|
@anonymoususer72041 #757 has been merged. |
319ad64 to
21e8484
Compare
f683762 to
74c0246
Compare
Summary
This PR stops persisting inline HTML markup for status change activity notes and cleans existing stored notes via a schema upgrade to remove previously persisted inline highlight markup.
Motivation
Persisting presentation markup in the database mixes data and UI concerns, makes future styling changes harder and can cause inconsistent output across different views and exports. By storing plain text and removing legacy markup during upgrade, we keep activity notes clean and ensure consistent, maintainable rendering going forward.