Skip to content

ci(release): run yarn tsc before build:all#565

Open
kaviththiranga wants to merge 1 commit into
openchoreo:mainfrom
kaviththiranga:fix-npm-release
Open

ci(release): run yarn tsc before build:all#565
kaviththiranga wants to merge 1 commit into
openchoreo:mainfrom
kaviththiranga:fix-npm-release

Conversation

@kaviththiranga
Copy link
Copy Markdown
Contributor

@kaviththiranga kaviththiranga commented May 18, 2026

Backstage's per-package builder needs .d.ts files in dist-types/
to exist before build:all; without them the release job fails with
"No declaration files found at ../../dist-types/...". Mirrors the
order already used by build-and-test.yml.

Summary by CodeRabbit

  • Chores
    • Enhanced release process to ensure TypeScript type declarations are properly compiled and available during the packaging step, improving build reliability.

Review Change Stack

Signed-off-by: Kavith Lokuhewage <kaviththiranga@gmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 11aebffe-64bd-4bf4-841f-9c43ee3696c4

📥 Commits

Reviewing files that changed from the base of the PR and between 0346616 and 594e172.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

📝 Walkthrough

Walkthrough

The PR adds a TypeScript compilation step to the release workflow. After Node.js setup and dependency installation, the workflow now executes yarn tsc to generate declaration files in dist-types/ before proceeding with the build and publish pipeline.

Changes

Release workflow TypeScript compilation

Layer / File(s) Summary
TypeScript declaration compilation
.github/workflows/release.yml
A new yarn tsc step is inserted into the release workflow to generate .d.ts declaration files that the packaging step requires before yarn build:all and subsequent publish/retag operations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • sameerajayasoma
  • stefinie123
  • LakshanSS

Poem

🐰 TypeScript types now compile with grace,
Declaration files find their place,
Before the build and publish run,
The .d.ts dance has begun! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the problem and solution but omits most required template sections like Goals, User Stories, Release Notes, Documentation, and others. Expand the description to include key sections from the template such as Goals, Release Notes, and Documentation impact, even if some sections are marked as N/A.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding a TypeScript compilation step before the build process in the CI release workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant