Skip to content

Add profile link to avatar menu#2452

Open
vyctorbrzezowski wants to merge 1 commit into
openclaw:mainfrom
vyctorbrzezowski:brzezowski/avatar-profile-menu
Open

Add profile link to avatar menu#2452
vyctorbrzezowski wants to merge 1 commit into
openclaw:mainfrom
vyctorbrzezowski:brzezowski/avatar-profile-menu

Conversation

@vyctorbrzezowski
Copy link
Copy Markdown
Contributor

@vyctorbrzezowski vyctorbrzezowski commented May 30, 2026

Summary

Adds a Profile item to the signed-in avatar menu so users can jump directly to their public profile.

Tests

  • bun run test -- src/__tests__/header.test.tsx
  • bun run ci:static
  • bunx tsc --noEmit
  • bun run ci:unit
  • AUTOREVIEW_AUTO_TESTS=0 .agents/skills/autoreview/scripts/autoreview --mode local --parallel-tests ""

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 30, 2026

@vyctorbrzezowski is attempting to deploy a commit to the Amantus Machina Team on Vercel.

A member of the Team first needs to authorize it.

@clawsweeper
Copy link
Copy Markdown

clawsweeper Bot commented May 30, 2026

Codex review: needs real behavior proof before merge. Reviewed May 30, 2026, 4:42 PM ET / 20:42 UTC.

Summary
The PR adds a conditional Profile link to the signed-in avatar dropdown and updates the header test mock and assertion for the profile route.

Reproducibility: not applicable. this is a navigation UI feature rather than a bug report. Source inspection confirms current main lacks the proposed Profile link in the signed-in avatar menu.

Review metrics: 1 noteworthy metric.

  • Changed surface: 2 files, +33/-6. The PR is a small UI-plus-test change, so review should focus on route correctness and visible behavior proof.

Merge readiness
Overall: 🧂 unranked krab
Proof: 🧂 unranked krab
Patch quality: 🐚 platinum hermit
Result: blocked until real behavior proof is added.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

  • [P1] Add a screenshot or short recording showing the signed-in avatar menu with the new Profile link and its destination, with private details redacted.

Proof guidance:

  • [P1] Needs real behavior proof before merge: The PR body lists tests only; the contributor should add a screenshot or short recording of the signed-in avatar menu with private details redacted, then update the PR body to trigger a fresh review.

Mantis proof suggestion
A signed-in browser proof would directly demonstrate the visible avatar-menu change. A maintainer can ask Mantis to capture proof by posting a new PR comment that starts with the OpenClaw Mantis account mention, followed by:

visual task: verify that a signed-in user avatar menu includes a Profile link to that user's public profile.

Risk before merge

  • [P1] Contributor real behavior proof is missing for a visible UI change; tests are supplemental but do not show the signed-in dropdown behavior in a real app session.

Maintainer options:

  1. Decide the mitigation before merge
    Merge a narrow avatar-menu Profile link after visible signed-in UI proof and normal checks confirm the link opens the current user's public /user/$handle profile.
  2. Pause or close
    Do not merge this PR until maintainers decide whether the risk is worth taking.

Next step before merge

  • [P1] The remaining blocker is contributor-supplied real UI proof, not an automated code repair.

Security
Cleared: The diff only adds a local UI link/icon and test adjustments, with no dependency, CI, secret, auth, or supply-chain surface change.

Review details

Best possible solution:

Merge a narrow avatar-menu Profile link after visible signed-in UI proof and normal checks confirm the link opens the current user's public /user/$handle profile.

Do we have a high-confidence way to reproduce the issue?

Not applicable; this is a navigation UI feature rather than a bug report. Source inspection confirms current main lacks the proposed Profile link in the signed-in avatar menu.

Is this the best way to solve the issue?

Yes, adding one conditional Link to the existing /user/$handle route is the narrow maintainable path; the remaining blocker is proof, not a code-direction concern.

AGENTS.md: found and applied where relevant.

Codex review notes: model gpt-5.5, reasoning high; reviewed against 9aa3f37ee192.

Label changes

Label changes:

  • add P3: This is low-risk navigation polish for an existing profile route with limited blast radius.
  • add rating: 🧂 unranked krab: Overall readiness is 🧂 unranked krab; proof is 🧂 unranked krab and patch quality is 🐚 platinum hermit.
  • add status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask. Needs real behavior proof before merge: The PR body lists tests only; the contributor should add a screenshot or short recording of the signed-in avatar menu with private details redacted, then update the PR body to trigger a fresh review.

Label justifications:

  • P3: This is low-risk navigation polish for an existing profile route with limited blast radius.
  • rating: 🧂 unranked krab: Overall readiness is 🧂 unranked krab; proof is 🧂 unranked krab and patch quality is 🐚 platinum hermit.
  • status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask. Needs real behavior proof before merge: The PR body lists tests only; the contributor should add a screenshot or short recording of the signed-in avatar menu with private details redacted, then update the PR body to trigger a fresh review.
Evidence reviewed

What I checked:

Likely related people:

  • Patrick Erichsen: Current-main blame attributes the existing avatar dropdown block to 875f026, and recent Header history includes an auth-related header fix. (role: recent area contributor; confidence: high; commits: 875f026a2300, ff75a7e9ae23; files: src/components/Header.tsx, src/__tests__/header.test.tsx)
  • vyctorbrzezowski: Prior merged history includes header avatar control work and publisher/profile foundation work, so the PR author also has current-main area history beyond this branch. (role: adjacent header/profile contributor; confidence: high; commits: 8a6efc236a11, 8bd7be9d04f0, 321df223b2ef; files: src/components/Header.tsx, src/routes/user/$handle.tsx, convex/publishers.ts)
  • Jason: The /user/$handle route was added by the canonical profile-route commit, which is the destination this PR links to. (role: canonical profile route contributor; confidence: medium; commits: 0dd91f130e80; files: src/routes/user/$handle.tsx)
  • Peter Steinberger: The earlier user menu and theme-toggle work appears in the feature history for Header.tsx. (role: original user menu contributor; confidence: medium; commits: 320f431f2d1c; files: src/components/Header.tsx, src/styles.css)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@vyctorbrzezowski vyctorbrzezowski marked this pull request as ready for review May 30, 2026 20:37
@clawsweeper clawsweeper Bot added rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. P3 Low-priority cleanup, docs, polish, ergonomics, or speculative work. labels May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-priority cleanup, docs, polish, ergonomics, or speculative work. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant