feat: allow official skill card uploads#2458
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Codex review: needs real behavior proof before merge. Reviewed May 31, 2026, 12:06 PM ET / 16:06 UTC. Summary Reproducibility: not applicable. as a bug reproduction; this is a feature PR. Source inspection confirms current main rejects direct Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Land this only after the official-org-only trusted-card contract is recorded in specs/API docs and the contributor adds redacted real publish/readback proof for both accepted official and rejected or stripped community cases. Do we have a high-confidence way to reproduce the issue? Not applicable as a bug reproduction; this is a feature PR. Source inspection confirms current main rejects direct Is this the best way to solve the issue? Partly: the server-side official-org gate is the right narrow boundary, but the solution is incomplete until the trust contract is documented and proven in a real publish/readback setup. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against 9fc2da4dc437. Label changesLabel changes:
Label justifications:
Evidence reviewedSecurity concerns:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Summary
skill-card.mdTests
bunx vitest run -c vitest.config.ts convex/lib/officialPublishers.test.ts convex/lib/skillPublish.test.ts convex/lib/skillCards.test.ts convex/skillCards.test.ts convex/httpApiV1.handlers.test.tsbunx vitest run -c vitest.config.ts src/cli/commands/publish.test.ts src/cli/commands/sync.test.tsbun run format:check -- docs/quickstart.md docs/cli.md convex/lib/officialPublishers.test.ts convex/lib/skillPublish.test.ts convex/lib/skillCards.test.ts convex/skillCards.test.ts convex/httpApiV1.handlers.test.ts packages/clawhub/src/cli/commands/publish.test.ts packages/clawhub/src/cli/commands/sync.test.tsbun run lint -- docs/quickstart.md docs/cli.md convex/lib/officialPublishers.test.ts convex/lib/officialPublishers.ts convex/lib/skillPublish.test.ts convex/lib/skillPublish.ts convex/lib/skillCards.test.ts convex/lib/skillCards.ts convex/skillCards.test.ts convex/skillCards.ts convex/httpApiV1.handlers.test.ts convex/httpApiV1/skillsV1.ts convex/skills.ts packages/clawhub/src/cli/commands/publish.test.ts packages/clawhub/src/cli/commands/publish.ts packages/clawhub/src/cli/commands/sync.test.tsbunx tsc --noEmitbunx tsc -p packages/clawhub/tsconfig.json --noEmitNotes
Autoreview initially caught two gaps: bundled cards needed to be readable from
/card//verify, and the CLI should not preserve rootskill-card.mdfor ordinary owner publishes. Both are fixed here. A final autoreview rerun wedged emitting only model warnings, so I killed the stuck process after the targeted gates passed.