Favorites: no preview of share mountpoint

[ScharfViktor]

Initial Checklist

• I understand this is a bug report and questions should be posted in the Community Discussions
• I searched issues and couldn’t find anything (or linked relevant results below)

Bug Description

no preview on file list and left scrollbar in the preview

Reproduction Steps

• alan creates folder f1 with image files
• alan shares folder f1 to mary and shares image f1/file.jpg to mary
• mary opens shares with me and mark f1/file.jpg as favorite
• mary opens favorites

Expected Outcome

mountpoint file.jpg doesn't have preview but Report response contains has-preview=true

related opencloud-eu/opencloud#2511 - We need the ability to add and remove drives and mountpoints from the favorites list

Actual Outcome

mountpoint file.jpg has preview.

search show preview. see:

[JammingBen]

The main issue here is that the same file with the same file id is appearing twice in the file list. This happens because it has been shared 2 times with the user: directly as well as indirectly via a shared folder. Now I'm unsure if we should dedupe in the client, or if that's the server's job. It happens for favorites and search results (REPORT endpoint). @aduffeck what do you think?

[aduffeck]

Hm... I'm not 100% sure either but I tend to think that it would be better if the frontend dedups the results. It could maybe add a small note like "also present at ..." or something like that, while the backend can't really just omit one of the locations imo as that might be confusing and is just not precise.

[JammingBen]

Ok, I guess it's also the easiest solution (for now anyway), so let's do that. No need for notes, we will just dedupe by id.