replace inf bounds before setting param.maxUB to avoid unbounded solution#2643
Merged
Merged
Conversation
Contributor
Summary:
Failed Tests:No failed tests ✨ Github Test Reporter by CTRF 💚 |
Member
|
infeasibility \ne unbounded |
Contributor
Author
|
This PR is correcting a mistake I made in the previous PR that was already merged. I originally wrote: before: Since the lifted gecko model had some inf in ub, param.maxUB became Inf then propagated into relaxFBA_cappedL1 as the cap for the relaxation slacks (p, q, r), so the slacks become unbounded. that's why now I changed the order and put the 2nd block first. The PR also now corrects another issue: models without D were failing at rmfield(model, {'ctrs','dsense','d','C','D'}). Now C/D are only removed when they exist |
Contributor
Summary:
Failed Tests:No failed tests ✨ Github Test Reporter by CTRF 💚 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replace inf bounds before setting param.maxUB to avoid unbounded solution
I hereby confirm that I have:
developas a target branch (top left drop-down menu)(Note: You may replace [ ] with [X] to check the box)