Paint4Net Update - Resubmitted#2649
Merged
Merged
Conversation
Modifications made to Paint4Net in order to not rely on the Biograph function (now depreciated) for users who have more recent MatLab Versions (2023 +). Main functions (draw_by_rxn, draw_by_met)now utilise the digraph() function, but for users using older versions of MatLab with access to Biograph, the old functions have been preserved as bio_draw_by_rxn & bio_draw_by_met. Tests that rely on Biograph only work when using MatLab that has Biograph available. New functions should work on all versions. Main files changed for users with more recent versions of MatLab and others added for testing and maintaining function for users with access to Biograph.
Contributor
Summary:
Failed Tests:No failed tests ✨ Github Test Reporter by CTRF 💚 |
Updated function documentation and comments for clarity.
Updated function documentation and improved argument handling for bio_draw_by_rxn.
Updated function documentation and improved input handling.
Updated the findNearRxns function to improve documentation and clarify input/output parameters.
Contributor
Summary:
Failed Tests:No failed tests ✨ Github Test Reporter by CTRF 💚 |
2 similar comments
Contributor
Summary:
Failed Tests:No failed tests ✨ Github Test Reporter by CTRF 💚 |
Contributor
Summary:
Failed Tests:No failed tests ✨ Github Test Reporter by CTRF 💚 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifications made to Paint4Net in order to not rely on the Biograph function (now depreciated) for users who have more recent MatLab Versions (2023 +). Main functions (draw_by_rxn, draw_by_met)now utilise the digraph() function, but for users using older versions of MatLab with access to Biograph, the old functions have been preserved as bio_draw_by_rxn & bio_draw_by_met.
Tests that rely on Biograph only work when using MatLab that has Biograph available. New functions should work on all versions.
Main files changed for users with more recent versions of MatLab and others added for testing and maintaining function for users with access to Biograph.
Deleted Last Pull Request to make fresh fork and resubmitting here.
I hereby confirm that I have:
developas a target branch (top left drop-down menu)