Skip to content

Commit 0d8e6a6

Browse files
Merge pull request #75 from rob-tetrel/main
bump version to 2.0 and fix corim signing with azure (signing was refactored, and this was broken)
2 parents dbfc3be + 075387c commit 0d8e6a6

2 files changed

Lines changed: 16 additions & 3 deletions

File tree

Documentation/framework.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,16 @@ OCP Security Workgroup
7878
<td>Clarify publication process
7979
</td>
8080
</tr>
81+
<tr>
82+
<td>2.0
83+
</td>
84+
<td>March, 2026
85+
</td>
86+
<td> Alex Tzonkov
87+
</td>
88+
<td>Added CoRIM SFR support
89+
</td>
90+
</tr>
8191
</table>
8292

8393
# Glossary

shortform_report-main/OcpReportLib.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
44
This script is intended to be used by Security Review Providers who are
55
participating in the Open Compute Project's Firmware Security Review Framework.
6-
The script complies with version 0.3 (draft) of the Security Review Framework
6+
The script complies with version 2.0 of the Security Review Framework
77
document and supports the new CoRIM (CBOR) format.
88
99
More details about the OCP review framework can be found here:
@@ -138,7 +138,7 @@ def signature(self):
138138

139139

140140
class ShortFormReport(object):
141-
def __init__(self, framework_ver: str = "1.1"):
141+
def __init__(self, framework_ver: str = "2.0"):
142142
self.report = {}
143143
self.report["review_framework_version"] = f"{framework_ver}".strip()
144144
self.signed_json_report = None
@@ -708,7 +708,10 @@ def sign_corim_report_azure(self, vault: str, kid: str) -> bool:
708708
signer = AzureKeyVaultSigner(vault=vault, kid=kid)
709709

710710
# sign and return result
711-
return self._sign_corim_report_internal(signer)
711+
corim_cbor = self.get_report_as_corim_cbor()
712+
cose = cwt.COSE(alg_auto_inclusion=True, kid_auto_inclusion=True)
713+
self.signed_corim_report = cose.encode(corim_cbor, signers=[signer])
714+
return True
712715

713716
except Exception as e:
714717
print(f"Error signing CoRIM with cwt/azure: {e}")

0 commit comments

Comments
 (0)