Skip to content

ACL Counter header inconsistency #2246

Description

@Shaigai21

From inc/saiacl.h:

/*
 * By default, Byte Counter would be created and following
 * use of the below attributes would result in an error.
 *
 * - Both packet count and byte count set to disable
 * - Only Byte count used which is set to disable
 */

According to the comment above, default value for enabling byte count is true.

But for SAI_ACL_COUNTER_ATTR_ENABLE_BYTE_COUNT it is set to false:

/**
 * @brief Enable/disable byte count
 *
 * @type bool
 * @flags CREATE_ONLY
 * @default false
 */
SAI_ACL_COUNTER_ATTR_ENABLE_BYTE_COUNT,

I propose to change the default value to true.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions