Skip to content

[DASH SAI] Add dash outbound portmap#2137

Merged
kcudnik merged 5 commits intoopencomputeproject:masterfrom
jimmyzhai:pl_redirect_map
Mar 25, 2025
Merged

[DASH SAI] Add dash outbound portmap#2137
kcudnik merged 5 commits intoopencomputeproject:masterfrom
jimmyzhai:pl_redirect_map

Conversation

@jimmyzhai
Copy link
Copy Markdown
Collaborator

@jimmyzhai jimmyzhai commented Jan 28, 2025

Add API definitions of dash outbound portmap, referring to HLD PR: sonic-net/DASH#664

@kcudnik
Copy link
Copy Markdown
Collaborator

kcudnik commented Jan 28, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Contributor

@r12f r12f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do not merge it until we got the DASH HLD and PR merged.

@r12f
Copy link
Copy Markdown
Contributor

r12f commented Jan 29, 2025

@jimmyzhai , do you mind including the HLD PR in the PR description: sonic-net/DASH#664

(no rush and happy Chinese new year!)

@KrisNey-MSFT
Copy link
Copy Markdown

@mukeshmv for tagging

* @validonly SAI_OUTBOUND_CA_TO_PA_ENTRY_ATTR_ACTION == SAI_OUTBOUND_CA_TO_PA_ENTRY_ACTION_SET_PRIVATE_LINK_MAPPING
*/
SAI_OUTBOUND_CA_TO_PA_ENTRY_ATTR_OUTBOUND_PORT_MAP_ID,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need SAI_OUTBOUND_CA_TO_PA_ENTRY_ATTR_SVC_SRC_PREFIX and SAI_OUTBOUND_CA_TO_PA_ENTRY_ATTR_SVC_DST_PREFIX as well?

Copy link
Copy Markdown
Collaborator Author

@jimmyzhai jimmyzhai Mar 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated attributes to include them with ip/mask style.

@jimmyzhai
Copy link
Copy Markdown
Collaborator Author

@jimmyzhai , do you mind including the HLD PR in the PR description: sonic-net/DASH#664

(no rush and happy Chinese new year!)

Done

@jimmyzhai jimmyzhai force-pushed the pl_redirect_map branch 2 times, most recently from 2d62485 to ba09a4d Compare March 13, 2025 02:47
@jimmyzhai
Copy link
Copy Markdown
Collaborator Author

/azpw run

@tjchadaga
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@jimmyzhai
Copy link
Copy Markdown
Collaborator Author

/azpw run

@prsunny
Copy link
Copy Markdown
Collaborator

prsunny commented Mar 24, 2025

@r12f to signoff.

@prsunny
Copy link
Copy Markdown
Collaborator

prsunny commented Mar 24, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@jimmyzhai
Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Commenter does not have sufficient privileges for PR 2137 in repo opencomputeproject/SAI

@jimmyzhai
Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Commenter does not have sufficient privileges for PR 2137 in repo opencomputeproject/SAI

@jimmyzhai
Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Commenter does not have sufficient privileges for PR 2137 in repo opencomputeproject/SAI

@jimmyzhai
Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Junhua Zhai <junhua.zhai@outlook.com>
2/ Add ENI drop counters: port map miss, port map port range entry miss

Signed-off-by: Junhua Zhai <junhua.zhai@outlook.com>
Signed-off-by: Junhua Zhai <junhua.zhai@outlook.com>
Signed-off-by: Junhua Zhai <junhua.zhai@outlook.com>
Signed-off-by: Junhua Zhai <junhua.zhai@outlook.com>
@jimmyzhai
Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@kcudnik kcudnik merged commit 46e8391 into opencomputeproject:master Mar 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants