SAI proposal for Synchronous Ethernet#2146
SAI proposal for Synchronous Ethernet#2146tjchadaga merged 1 commit intoopencomputeproject:masterfrom
Conversation
| if (SAI_OBJECT_TYPE_SYNCE == oi->objecttype) | ||
| { | ||
| META_LOG_WARN("synce object %s not present on any object list (eg. VLAN_MEMBER is present on SAI_VLAN_ATTR_MEMBER_LIST)", oi->objecttypename); | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
why this exception is made ? seems like your objects are not SET on any attributes that's why you are getting this error, why you dont set it on any other attributes ?
There was a problem hiding this comment.
I have taken care of this. Kindly review again and let me know if this is fine.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rpmarvell
force-pushed
the
rpmarvell_synce_sai_proposal
branch
7 times, most recently
from
dfd5538 to
5d0b0cc
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@rpmarvell - could you please resolve branch conflicts? |
rpmarvell
force-pushed
the
rpmarvell_synce_sai_proposal
branch
from
5d0b0cc to
401cb11
Compare
| * @allownull true | ||
| * @default SAI_NULL_OBJECT_ID | ||
| */ | ||
| SAI_SYNCE_CLOCK_ATTR_SRC_PORT = SAI_SYNCE_CLOCK_ATTR_START, |
There was a problem hiding this comment.
why not to do in the regular way via setting the SyncE clock object to Port Object ? For example, SAI_PORT_ATTR_SYNCE_ENABLE with Sync Clock OID
Please consider additional parameters (per port with enabled SyncE):
- oper_frequency_diff - RO
- hold_over_acquired - RO
- synce_failure_code - RO
- synce_oper_status - RO [free-running, self-track, other-track, hold-over, hold-over-in-failure]
There was a problem hiding this comment.
According to the proposed model, a SyncE clock can synchronize with only a single port's frequency. Therefore, this SyncE clock object is designed to utilize a designated clock source attribute. Since this model is based on the SyncE clock, can we consider implementing the read-only attributes in the next phase? Additionally, the attribute SAI_SYNCE_CLOCK_ATTR_CLOCK_VALID is available to indicate the status of the SyncE clock. Please let me know if this is fine.
| * | ||
| * Returns the hardware clock-id associated | ||
| * | ||
| * @type sai_uint32_t |
There was a problem hiding this comment.
Addressed the comment. Thank you.!
|
@rpmarvell - please addres the comments and resolve branch conflicts |
|
@tjchadaga : I am working on it. |
Signed-off-by: rpmarvell <rperumal@marvell.com> Addressed the review comment from nvdia for the SyncE PR
rpmarvell
force-pushed
the
rpmarvell_synce_sai_proposal
branch
from
401cb11 to
2165302
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
4 participants
This proposal introduces Synchronous Ethernet(SyncE) to SAI with following details,