Add SAI port attribute to fetch PAM4 eye height values#2154
Merged
prgeor merged 1 commit intoopencomputeproject:masterfrom Mar 24, 2025
Merged
Add SAI port attribute to fetch PAM4 eye height values#2154prgeor merged 1 commit intoopencomputeproject:masterfrom
prgeor merged 1 commit intoopencomputeproject:masterfrom
Conversation
Collaborator
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 2154 in repo opencomputeproject/SAI |
Collaborator
Author
|
@kcudnik can you review? |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
seems like you are not on the master, can you rebase your change to master, squash and force push here again to satisfy validator |
Signed-off-by: Prince George <prgeor@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
eddyk-nvidia
approved these changes
Mar 20, 2025
kcudnik
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SAI port attribute to fetch PAM4 eye heights and widths of the lower, middle and upper eye of a PAM4 signal.
Eye height in mV
Eye width in psecs. If an implementation does not support then, -1
A narrower eye is more sensitive to jitter and smaller eye has lower SNR.
A good eye height and width threshold is implementation defined based upon the desired SNR, jitter tolerance etc for the application or deployment scenario
SAI_PORT_ATTR_PAM4_EYE_VALUES - Is the attribute introduced for PAM4 SerDes lanes.
SAI_PORT_ATTR_EYE_VALUES - Can be used for NRZ SerDes lanes