Add DSCP resolution from TC in packet trim#2155
Add DSCP resolution from TC in packet trim#2155tjchadaga merged 1 commit intoopencomputeproject:masterfrom
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
please provide meaningful description to PR |
| * @brief Dynamic DSCP resolution. | ||
| * | ||
| * In this mode, a new DSCP for the trimmed packet is resolved from the new TRIM_TC | ||
| * set by the application using per-port TC_TO_DSCP mapping |
There was a problem hiding this comment.
The saiqosmap.h defines only TC_AND_COLOR_TO_DSCP map, but no TC_TO_DSCP map, as part of the set of valid qos maps. In this case, a color value also need to be supplied if this mechanism is desired. Could you please clarify ?
SAI_QOS_MAP_TYPE_TC_AND_COLOR_TO_DSCP = 0x00000005,
There was a problem hiding this comment.
Color does not need to be supplied. The user can just map all the colors to same DSCP, since the TC is used for trimming.
There was a problem hiding this comment.
Or is it possible that different-colors are mapped to different DSCP values ? Is this a valid configuration ?
marian-pritsak
force-pushed
the
trim-tc
branch
2 times, most recently
from
d94f37a to
5123b4e
Compare
| SAI_SWITCH_ATTR_PACKET_TRIM_TC_VALUE, | ||
|
|
||
| /** | ||
| * @brief Queue mapping mode for a trimmed packet |
There was a problem hiding this comment.
Typo: DSCP mapping mode
There was a problem hiding this comment.
Thanks, fixed.
marian-pritsak
force-pushed
the
trim-tc
branch
3 times, most recently
from
eb30c0b to
a956e66
Compare
Signed-off-by: Marian Pritsak <marianp@mellanox.com>
|
@bandaru-viswanath could you pls approve the SAI PR, we could merge it. |
tjchadaga
requested review from
bandaru-viswanath and
kcudnik
and removed request for
bandaru-viswanath
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Please add description for this change |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@kcudnik Please approve the PR and we could merge. |
5 participants
It can be beneficial to support multiple DSCP values for trimmed packets sent out via different ports. For example, trimmed packets sent to hosts will get DSCP 5 whereas trimmed packets sent to uplink/spine will have DSCP 7. It is to allow to the destination NIC to know where congestion happened - on downlinks to servers or in the fabric. Such information can be used for a better decision making on how to react to the state of network.