[saithrift] Allow overriding variable SAI_HEADER_DIR#2161
Merged
kcudnik merged 1 commit intoopencomputeproject:masterfrom Apr 3, 2025
Merged
[saithrift] Allow overriding variable SAI_HEADER_DIR#2161kcudnik merged 1 commit intoopencomputeproject:masterfrom
kcudnik merged 1 commit intoopencomputeproject:masterfrom
Conversation
Signed-off-by: Junhua Zhai <junhua.zhai@outlook.com>
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jimmyzhai
changed the title
kcudnik
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #2097 breaks the DASH saithrift, which uses /usr/include/sai/ as SAI header directory.
Use conditional assignment
?=to assignSAI_HEADER_DIRwith default value, then it can be overridden via make command-line argument or environment variable.