Skip to content

SAI LPO attributes#2178

Merged
tjchadaga merged 1 commit intoopencomputeproject:masterfrom
pullaraogunda:sai_lpo_attributes
Sep 5, 2025
Merged

SAI LPO attributes#2178
tjchadaga merged 1 commit intoopencomputeproject:masterfrom
pullaraogunda:sai_lpo_attributes

Conversation

@pullaraogunda
Copy link
Copy Markdown
Contributor

SAI port serdes attributes support for Linear Pluggable Optics (LPO)

@tjchadaga
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@tjchadaga tjchadaga requested a review from prgeor June 26, 2025 15:05
@tjchadaga tjchadaga added the reviewed PR is discussed in SAI Meeting label Jun 26, 2025
Comment thread doc/SAI_LPO_Attributes.md Outdated
* @default empty
*/
SAI_PORT_SERDES_ATTR_REACH_MODE,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check if this attribute is a standard one, defined in the spec and can be beneficial for all vendors. If it is vendor-specific please consider using the SAI "custom" infrastructure (#2122)

Comment thread doc/SAI_LPO_Attributes.md
@tjchadaga
Copy link
Copy Markdown
Collaborator

@eddyk-nvidia, @prgeor - could you please complete the review on this?

Comment thread inc/saiport.h Outdated
* @flags CREATE_AND_SET
* @default empty
*/
SAI_PORT_SERDES_ATTR_REACH_MODE,
Copy link
Copy Markdown
Collaborator

@prgeor prgeor Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pullaraogunda can we move this to custom attribute since this is not applicable for all vendors ?

    SAI_PORT_SERDES_ATTR_END,

    /** Custom range base value */
    SAI_PORT_SERDES_ATTR_CUSTOM_RANGE_START = 0x10000000,

    /** End of custom range base */
    SAI_PORT_SERDES_ATTR_CUSTOM_RANGE_END

@prgeor
Copy link
Copy Markdown
Collaborator

prgeor commented Sep 4, 2025

@tjchadaga @rlhui could you please merge?

@tjchadaga
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@tjchadaga
Copy link
Copy Markdown
Collaborator

@pullaraogunda - could you please squash your commits?

Signed-off-by: pullarao <pullarao.gunda@broadcom.com>
@pullaraogunda
Copy link
Copy Markdown
Contributor Author

@pullaraogunda - could you please squash your commits?

@tjchadaga Done

@tjchadaga
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@tjchadaga tjchadaga merged commit f56f534 into opencomputeproject:master Sep 5, 2025
3 checks passed
prgeor pushed a commit to prgeor/SAI that referenced this pull request Sep 11, 2025
Signed-off-by: pullarao <pullarao.gunda@broadcom.com>
tjchadaga pushed a commit that referenced this pull request Oct 6, 2025
Signed-off-by: pullarao <pullarao.gunda@broadcom.com>
pandeytejas pushed a commit to pandeytejas/SAI that referenced this pull request Oct 7, 2025
Signed-off-by: pullarao <pullarao.gunda@broadcom.com>
pandeytejas pushed a commit to pandeytejas/SAI that referenced this pull request Oct 7, 2025
Signed-off-by: pullarao <pullarao.gunda@broadcom.com>
pandeytejas pushed a commit to pandeytejas/SAI that referenced this pull request Oct 7, 2025
Signed-off-by: pullarao <pullarao.gunda@broadcom.com>
pandeytejas pushed a commit to pandeytejas/SAI that referenced this pull request Oct 7, 2025
Signed-off-by: pullarao <pullarao.gunda@broadcom.com>
pandeytejas pushed a commit to pandeytejas/SAI that referenced this pull request Oct 7, 2025
Signed-off-by: pullarao <pullarao.gunda@broadcom.com>
pandeytejas pushed a commit to pandeytejas/SAI that referenced this pull request Oct 7, 2025
Signed-off-by: pullarao <pullarao.gunda@broadcom.com>
tjchadaga pushed a commit that referenced this pull request Oct 10, 2025
Signed-off-by: pullarao <pullarao.gunda@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviewed PR is discussed in SAI Meeting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants