Adding custom range base values#2179
Merged
tjchadaga merged 2 commits intoopencomputeproject:masterfrom Jul 16, 2025
Merged
Conversation
Signed-off-by: Dhruvkumar Patel <pdhruvkumarr@marvell.com>
kcudnik
approved these changes
Jun 20, 2025
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@kcudnik @tjchadaga Can this PR be merged or does it need to be discussed in the SAI community meeting? This PR is just defining the missing CUSTOM RANGE BASE. |
Collaborator
|
@rck-innovium, @pdhruv-marvell - we can just go ahead and merge this. Please resolve branch conflicts |
Contributor
Author
|
@tjchadaga - Branch conflict resolved |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tjchadaga
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title:
Add missing CUSTOM_RANGE_BASE values to enum definitions
Description:
This PR fixes an issue where the CUSTOM_RANGE_BASE value was missing from some enum types/stats.Specifically, the following additions were made:
Why:
These enum types lacked defined custom range base values, making it impossible to use extended or custom values reliably.