Proposal for MACSec SAI Attribute enhancements#2213
Merged
tjchadaga merged 1 commit intoopencomputeproject:masterfrom Mar 11, 2026
Merged
Proposal for MACSec SAI Attribute enhancements#2213tjchadaga merged 1 commit intoopencomputeproject:masterfrom
tjchadaga merged 1 commit intoopencomputeproject:masterfrom
Conversation
rushanmu-cisco
force-pushed
the
macsec_secure_policy
branch
from
3d9012b to
3d68794
Compare
rushanmu-cisco
changed the title
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 2213 in repo opencomputeproject/SAI |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 2213 in repo opencomputeproject/SAI |
Collaborator
|
@rushanmu-cisco - please squash your commits |
rushanmu-cisco
force-pushed
the
macsec_secure_policy
branch
from
a60d624 to
9deba66
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rushanmu-cisco
force-pushed
the
macsec_secure_policy
branch
from
cd971f7 to
85d50a8
Compare
Contributor
Author
|
@tjchadaga, can you please help trigger azp? Thank you! |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@JaiOCP , @judyjoseph - could you please help review? |
1 similar comment
Contributor
Author
|
@JaiOCP , @judyjoseph - could you please help review? |
rushanmu-cisco
force-pushed
the
macsec_secure_policy
branch
from
006dbfc to
d2b28de
Compare
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 2213 in repo opencomputeproject/SAI |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rushanmu-cisco
force-pushed
the
macsec_secure_policy
branch
from
2f50064 to
aae9253
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
This pull request proposes enhancements to the SAI MACsec API to support additional configuration options as defined in IEEE 802.1AE standard. The changes add three major capabilities: security mode configuration (Must Secure/Should Secure), confidentiality offset configuration, and Tag Control Information (TCI) field configuration for End Station (ES) and Single Copy Broadcast (SCB) bits.
Changes:
- Added
sai_macsec_port_security_mode_tenum andSAI_MACSEC_PORT_ATTR_SECURITY_MODEattribute to configure whether the port operates in fail-open (Should Secure) or fail-closed (Must Secure) mode - Added
SAI_MACSEC_SC_ATTR_CONFIDENTIALITY_OFFSETattribute to allow selective unencrypted bytes in the payload while maintaining integrity protection - Added
SAI_MACSEC_SC_ATTR_USE_ESandSAI_MACSEC_SC_ATTR_USE_SCBattributes for TCI field configuration
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| inc/saimacsec.h | Adds new enum for security modes, new port attribute for security mode configuration, and new SC attributes for confidentiality offset and TCI bits (ES/SCB) |
| doc/SAI-Proposal-MACSec-Enhancements.md | Provides detailed technical documentation explaining the rationale, usage, and API workflow for the new MACsec enhancements with code examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rushanmu-cisco
force-pushed
the
macsec_secure_policy
branch
2 times, most recently
from
59dcded to
78781ab
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rushanmu-cisco
force-pushed
the
macsec_secure_policy
branch
from
78781ab to
d08162d
Compare
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 2213 in repo opencomputeproject/SAI |
Signed-off-by: rushanmu <rushanmu@cisco.com>
rushanmu-cisco
force-pushed
the
macsec_secure_policy
branch
from
d08162d to
e1ab78f
Compare
Contributor
|
@AnandhiDhanabalan, Pls review this PR |
Contributor
Author
|
@tjchadaga Can you please help trigger azure pipelines? |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@JaiOCP ,@AnandhiDhanabalan - please help review this PR |
Contributor
|
Changes looks good to me. I approve the changes. |
AnandhiDhanabalan
approved these changes
Mar 6, 2026
Contributor
AnandhiDhanabalan
left a comment
AnandhiDhanabalan
left a comment
There was a problem hiding this comment.
Changes look good.
Contributor
Author
|
@tjchadaga Can you please help merge/integrate? |
tjchadaga
approved these changes
Mar 11, 2026
tjchadaga
pushed a commit
that referenced
this pull request
Mar 31, 2026
Signed-off-by: rushanmu <rushanmu@cisco.com>
cursor Bot
pushed a commit
to yuriilisovskyi/SAI
that referenced
this pull request
Apr 7, 2026
Signed-off-by: rushanmu <rushanmu@cisco.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings support for Configuration of MACSec security modes, Confidentiality offset and extended TCI configuration