SAI API Performance Monitoring#2265
Open
JaiOCP wants to merge 5 commits intoopencomputeproject:masterfrom
Open
SAI API Performance Monitoring#2265JaiOCP wants to merge 5 commits intoopencomputeproject:masterfrom
JaiOCP wants to merge 5 commits intoopencomputeproject:masterfrom
Conversation
Signed-off-by: JaiOCP <jai.kumar@broadcom.com>
Signed-off-by: JaiOCP <jai.kumar@broadcom.com>
deepak-singhal0408
left a comment
deepak-singhal0408
left a comment
There was a problem hiding this comment.
Review comments on sai_perfdata_t struct — precision, capacity, and completeness for real-world SAI performance monitoring.
|
thanks @JaiOCP .. Could you push the updated PR. and resolve the conflicts? |
Contributor
Author
I have to open a new PR. PR branch is diverged too much from the origin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings in the performance monitoring of the SAI API. This proposal was presented in OCP 2023.