Skip to content

NHG with Unequal Cost Members #2302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JaiOCP wants to merge 2 commits into
base: master
Choose a base branch
from
+25 −0
Open

NHG with Unequal Cost Members #2302

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95c4771
NHG with Unequal Cost Members
JaiOCP Jun 22, 2026
6075ead
NHG with Weighted or unWeighted Members
JaiOCP Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions inc/sainexthopgroup.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,22 @@ typedef struct _sai_next_hop_group_hw_protection_switchover_notification_data_t
sai_object_list_t failed_next_hop_groups;
} sai_next_hop_group_hw_protection_switchover_notification_data_t;

/**
* @brief Next hop group is configured with weights or not
*/
typedef enum _sai_next_hop_group_members_weight_t
{
/** This is for legacy platforms where this attribute is don't care */
SAI_NEXT_HOP_GROUP_MEMBERS_WEIGHT_DONT_CARE,

/** Next hop group members are weighted */
SAI_NEXT_HOP_GROUP_MEMBERS_WEIGHT_WEIGHTED,

/** Next hop group members are unweighted */
SAI_NEXT_HOP_GROUP_MEMBERS_WEIGHT_UNWEIGHTED,

} sai_next_hop_group_members_weight_t;

/**
* @brief Attribute id for next hop
*/
Expand Down Expand Up @@ -359,6 +375,15 @@ typedef enum _sai_next_hop_group_attr_t
*/
SAI_NEXT_HOP_GROUP_ATTR_ADMIN_ROLE,

/**
* @brief This attribute indicates if all the members are with weights or are unweighted

@rck-innovium rck-innovium Jul 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please add some more text to bring out that this attribute is an hint. For e.g., a NOS can set the type as SAI_NEXT_HOP_GROUP_MEMBERS_WEIGHT_WEIGHTED and still not give any weights to the members. On the other hand, if the NOS sets the type as SAI_NEXT_HOP_GROUP_MEMBERS_WEIGHT_UNWEIGHTED, the NOS MUST NOT give any weights to the members.

    "This attribute is for the NOS to provide a hint that members of this group will be created with weights. When this is set as SAI_NEXT_HOP_GROUP_MEMBERS_WEIGHT_UNWEIGHTED, it allows the SAI implementation to optimize hardware resources for ECMP."

  2. We need to describe the relationship with SAI_NEXT_HOP_GROUP_ATTR_TYPE.
    Example:
    @validonly SAI_NEXT_HOP_GROUP_ATTR_TYPE == SAI_NEXT_HOP_GROUP_TYPE_DYNAMIC_UNORDERED_ECMP or SAI_NEXT_HOP_GROUP_ATTR_TYPE == SAI_NEXT_HOP_GROUP_TYPE_DYNAMIC_ORDERED_ECMP

*
* @type sai_next_hop_group_members_weight_t
* @flags CREATE_ONLY
* @default SAI_NEXT_HOP_GROUP_MEMBERS_WEIGHT_DONT_CARE
*/
SAI_NEXT_HOP_GROUP_ATTR_MEMBERS_WEIGHT,

Comment thread
JaiOCP marked this conversation as resolved.
/**
* @brief End of attributes
*/
Expand Down
Loading