Skip to content

Commit 85fafc0

Browse files
committed
Responding to gemini-code-assist Bot Review
1 parent c1498ea commit 85fafc0

4 files changed

Lines changed: 6 additions & 3 deletions

File tree

feature/system/control_plane_traffic/otg_tests/default_copp_test/default_copp_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -157,9 +157,9 @@ func extractPlatformFromResponse(t *testing.T, resp *gpb.GetResponse) string {
157157
return ""
158158
}
159159

160-
func getPlatformConfig(t *testing.T, gnmiClient gpb.GNMIClient) *platformConfig {
160+
func getPlatformConfig(t *testing.T, ctx context.Context, gnmiClient gpb.GNMIClient) *platformConfig {
161161
t.Helper()
162-
resp, err := gnmiClient.Get(context.Background(), &gpb.GetRequest{
162+
resp, err := gnmiClient.Get(ctx, &gpb.GetRequest{
163163
Path: []*gpb.Path{{
164164
Elem: []*gpb.PathElem{
165165
{Name: "components"},
@@ -497,7 +497,7 @@ func TestCoppSystem(t *testing.T) {
497497
return
498498
}
499499

500-
platCfg := getPlatformConfig(t, gnmiClient)
500+
platCfg := getPlatformConfig(t, ctx, gnmiClient)
501501

502502
ce := &commonEntities{
503503
dut: dut,

internal/deviations/deviations.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2185,6 +2185,7 @@ func BgpMultipathPathsUnderPeerGroupUnsupported(dut *ondatra.DUTDevice) bool {
21852185
}
21862186

21872187
// CoppL2UnicastUnsupported returns true if the device does not support L2 unicast COPP counter validation.
2188+
// Arista: https://partnerissuetracker.corp.google.com/issues/493487459
21882189
func CoppL2UnicastUnsupported(dut *ondatra.DUTDevice) bool {
21892190
return lookupDUTDeviations(dut).GetCoppL2UnicastUnsupported()
21902191
}

proto/metadata.proto

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1334,6 +1334,7 @@ message Metadata {
13341334
string ciscoxr_vendordrop_ft = 424;
13351335

13361336
// Device does not support L2 unicast COPP counter validation.
1337+
// Arista: https://partnerissuetracker.corp.google.com/issues/493487459
13371338
bool copp_l2_unicast_unsupported = 425;
13381339

13391340
// Reserved field numbers and identifiers.

proto/metadata_go_proto/metadata.pb.go

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)