Skip to content

Fix package name for setup_service/setup_service.go as per the language standards #5320

@RishabhAgarwal-2001

Description

@RishabhAgarwal-2001

Context: Pull Request #5314 was recently merged to address Copybara synchronization failures by renaming the internal package from setupservice to setup_service. This was done to match the directory name ( source).

Problem: As noted during the review, the name setup_service contains an underscore, which violates the repository's Go Style Guide ( source). Using underscores in Go package names is unidiomatic and discouraged ( source).

Proposed Solution To satisfy both the Copybara tooling requirements and the style guide, we should:

  1. Rename the directory from feature/gnsi/certz/tests/internal/setup_service/ to feature/gnsi/certz/tests/internal/setupservice/ ( source).
  2. Update the package declaration inside the Go files back to package setupservice ( source).
  3. Update all import references and remove any redundant import aliases in files like trustbundle_test.go ( source).

Reference

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions