Skip to content

Fix ACCTZ clock skew by using DUT clock for RecordSubscribe timestamps #5347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pjacakArista wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −5
Open

Fix ACCTZ clock skew by using DUT clock for RecordSubscribe timestamps #5347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions feature/gnsi/acctz/tests/record_payload_truncation/record_payload_truncation_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,14 @@ func TestAccountzRecordPayloadTruncation(t *testing.T) {
helpers.GnmiCLIConfig(t, dut, communitySetCLIConfig)
}

startTime := time.Now()

// Get the current time from the router via gNMI to avoid clock skew issues.
startTime := helpers.GetRouterTime(t, dut)
acctzClient := dut.RawAPIs().GNSI(t).AcctzStream()
acctzSubClient, err := acctzClient.RecordSubscribe(context.Background(), &acctzpb.RecordRequest{
Timestamp: timestamppb.New(startTime),
Timestamp: &timestamppb.Timestamp{
Seconds: startTime.Unix(),
Nanos: 0,
},
})
if err != nil {
t.Fatalf("Failed to subscribe to acctz records: %v", err)
Expand Down
5 changes: 3 additions & 2 deletions feature/gnsi/acctz/tests/record_subscribe_full/record_subscribe_full_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import (

"github.com/openconfig/featureprofiles/internal/deviations"
"github.com/openconfig/featureprofiles/internal/fptest"
"github.com/openconfig/featureprofiles/internal/helpers"
"github.com/openconfig/featureprofiles/internal/security/acctz"
acctzpb "github.com/openconfig/gnsi/acctz"
"github.com/openconfig/ondatra"
Expand Down Expand Up @@ -53,8 +54,8 @@ func TestAccountzRecordSubscribeFull(t *testing.T) {
} else {
acctz.SetupUsers(t, dut, false)
}
startTime := time.Now()

// Get the current time from the router via gNMI to avoid clock skew issues.
startTime := helpers.GetRouterTime(t, dut)
// Get gNSI record subscribe client.
requestTimestamp := &timestamppb.Timestamp{
Seconds: startTime.Unix(),
Expand Down
Loading