Update remote_syslog_test.go

[AmrNJ]

• Added CLI function to configure global Nokia subsystem-facility.
• Replaced hardcoded loopback 0 ('lo0') interface configs with dynamic loopback search.
• Updated deviations for Nokia.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the remote syslog test suite to improve compatibility with Nokia devices and enhance the reliability of the test environment. Key changes include dynamic loopback interface discovery, more robust VRF configuration handling, and updated packet validation criteria to ensure tests pass across different network configurations.

Highlights

• Nokia Vendor Support: Added a helper function to push Nokia-specific CLI configurations via gNMI and integrated it into the test setup.
• Loopback Interface Selection: Improved the loopback interface selection logic to dynamically find an available interface instead of defaulting to index 0.
• VRF Configuration Improvements: Enhanced interface management by ensuring interfaces are deleted from the default network instance before being added to a VRF and restoring them during cleanup.
• Packet Validation: Updated packet validation logic to accept both loopback and source IP addresses, increasing test robustness.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5456 / fcb77fd

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		TR-6.1: Remote Syslog feature config	ecafc72b	Log
Cisco 8000E		TR-6.1: Remote Syslog feature config	1417045e	Log
Cisco XRd		TR-6.1: Remote Syslog feature config	d383b319	Log
Juniper ncPTX		TR-6.1: Remote Syslog feature config	2f799f3d	Log
Nokia SR Linux		TR-6.1: Remote Syslog feature config	dabe0f91	Log
Openconfig Lemming		TR-6.1: Remote Syslog feature config	c335d160	Log

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		TR-6.1: Remote Syslog feature config
Cisco 8808		TR-6.1: Remote Syslog feature config
Juniper PTX10008		TR-6.1: Remote Syslog feature config
Nokia 7250 IXR-10e		TR-6.1: Remote Syslog feature config

Help

[gemini-code-assist]

Code Review

This pull request updates the remote syslog test to include Nokia-specific configuration handling, dynamic loopback interface discovery, and more comprehensive cleanup of network instances and logging configurations. Key feedback identifies a bug where gnmi.Delete uses an incorrect interface key format, potentially leading to configuration conflicts. Additionally, the reviewer recommends against weakening the packet validation logic—which now accepts physical interface IPs—suggesting instead that the test should strictly verify loopback source addresses or utilize deviations for specific platforms.

[AmrNJ]

/fptest

[AmrNJ]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces several updates to the remote syslog test, including platform-specific exceptions for Nokia, a more robust loopback interface selection mechanism, and improved VRF handling that ensures interfaces are cleared from the default network instance before reassignment. Additionally, packet validation now accounts for DUT source IPs alongside loopback addresses. Feedback was provided regarding the use of an internal Google import path which would break public builds, and a suggestion was made to use the deviations package for vendor-specific CLI configurations to maintain better test abstraction.

[AmrNJ]

/fptest all

[AmrNJ]

@rohit-rp Vendor dependent configuration is removed from the code and is handled as part of the base config.