Skip to content

Adding OTG Utility Function#5462

Open
ANISH-GOTTAPU wants to merge 3 commits into
openconfig:mainfrom
open-traffic-generator:otgutil_waitfortraffic
Open

Adding OTG Utility Function#5462
ANISH-GOTTAPU wants to merge 3 commits into
openconfig:mainfrom
open-traffic-generator:otgutil_waitfortraffic

Conversation

@ANISH-GOTTAPU
Copy link
Copy Markdown
Contributor

This Utility function will do a polling mechanism to check if the Transmit packets received at the far end.

Usage:

	otgutils.WaitForTxPacketsReceived(t, otgutils.TrafficTestParams{Config: otgConfig, Ate: ate})

@ANISH-GOTTAPU ANISH-GOTTAPU requested a review from a team as a code owner May 14, 2026 05:38
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adds a new utility function to the internal OTG package to streamline traffic validation. By providing a standardized way to wait for packet convergence, it simplifies the testing process for verifying that transmitted packets match received counts across configured flows.

Highlights

  • New Utility Function: Introduced WaitForTxPacketsReceived to facilitate traffic verification in OTG tests.
  • Polling Mechanism: Implemented a polling-based approach using gnmi.Watch to ensure transmitted packets are successfully received at the far end.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot
Copy link
Copy Markdown

OpenConfigBot commented May 14, 2026

Pull Request Functional Test Report for #5462 / adc42d6

No tests identified for validation.

Help

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new utility function, WaitForTxPacketsReceived, in internal/otgutils/traffic.go to monitor and wait for traffic convergence across OTG flows. Feedback suggests optimizing the implementation by watching the Counters() node directly to avoid inefficient gnmi.Get calls within the watch loop and refactoring the sequential flow processing to run in parallel or use wildcard paths for better performance.

Comment thread internal/otgutils/traffic.go Outdated
Comment thread internal/otgutils/traffic.go Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants