Adding OTG Utility Function#5462
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request adds a new utility function to the internal OTG package to streamline traffic validation. By providing a standardized way to wait for packet convergence, it simplifies the testing process for verifying that transmitted packets match received counts across configured flows. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new utility function, WaitForTxPacketsReceived, in internal/otgutils/traffic.go to monitor and wait for traffic convergence across OTG flows. Feedback suggests optimizing the implementation by watching the Counters() node directly to avoid inefficient gnmi.Get calls within the watch loop and refactoring the sequential flow processing to run in parallel or use wildcard paths for better performance.
This Utility function will do a polling mechanism to check if the Transmit packets received at the far end.
Usage: