Skip to content

P200 | Health-1.1 fix #5465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
suredhar wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

P200 | Health-1.1 fix #5465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion feature/system/health/tests/system_generic_health_check/system_generic_health_check_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ func TestLineCardsNoHighCPUSpike(t *testing.T) {
}
}
if len(baseLCs) == 0 {
t.Errorf("ERROR: No Cisco linecard CPU base components found")
t.Skipf("Skip the test on No Cisco linecard CPU base components found.")
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Use t.Fatalf instead of t.Skip when critical components like Cisco linecard CPUs are not found, as their absence should be considered a fatal test failure in health check tests. Additionally, ensure the message follows Go style: lowercase and no trailing punctuation.

Suggested change
t.Skipf("Skip the test on No Cisco linecard CPU base components found.")
t.Fatalf("no Cisco linecard CPU base components found")
References
  1. Go style guidelines specify that error and status messages should be lowercase and not end with punctuation. (link)
  2. When monitoring critical processes in a test, use t.Fatalf if a process is not found, as its absence should be considered a fatal test failure.
  3. In tests, t.Fatalf is preferred over t.Errorf when a failure makes subsequent test steps meaningless, as this fails fast and reduces overall test execution time.

}
// Skip non-removable linecards
var removable []string
Expand Down
Loading