Skip to content

TestID-16.4: Fixes for export policy, drain policy, and prefix validation #5468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nakulnayak wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −6
Open

TestID-16.4: Fixes for export policy, drain policy, and prefix validation #5468

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51702f0
TestID-16.4: Fix export policy, drain policy, and prefix validation …
nakulnayak May 14, 2026
cd58c3b
TestID-16.4: Fix export policy, drain policy, and prefix validation …
nakulnayak May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions feature/gribi/otg_tests/gribi_to_bgp_redistribution/gribi_to_bgp_redistribution_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,10 +245,10 @@ func configureRoutingPolicies(t *testing.T, dut *ondatra.DUTDevice) {
// ----------------------------
// ATTACH EXPORT POLICY TO BGP
// ----------------------------
policy := root.GetOrCreateNetworkInstance(deviations.DefaultNetworkInstance(dut)).GetOrCreateProtocol(oc.PolicyTypes_INSTALL_PROTOCOL_TYPE_BGP, "BGP").GetOrCreateBgp().GetOrCreateNeighbor(atePort2.IPv4).GetOrCreateAfiSafi(oc.BgpTypes_AFI_SAFI_TYPE_IPV4_UNICAST).GetOrCreateApplyPolicy()
policy := root.GetOrCreateNetworkInstance(vrfName).GetOrCreateProtocol(oc.PolicyTypes_INSTALL_PROTOCOL_TYPE_BGP, "BGP").GetOrCreateBgp().GetOrCreateNeighbor(atePort2.IPv4).GetOrCreateAfiSafi(oc.BgpTypes_AFI_SAFI_TYPE_IPV4_UNICAST).GetOrCreateApplyPolicy()
policy.SetExportPolicy([]string{bgpExportPol})
policy.SetDefaultExportPolicy(oc.RoutingPolicy_DefaultPolicyType_REJECT_ROUTE)
path := gnmi.OC().NetworkInstance(deviations.DefaultNetworkInstance(dut)).Protocol(oc.PolicyTypes_INSTALL_PROTOCOL_TYPE_BGP, "BGP").Bgp().Neighbor(atePort2.IPv4).AfiSafi(oc.BgpTypes_AFI_SAFI_TYPE_IPV4_UNICAST).ApplyPolicy()
path := gnmi.OC().NetworkInstance(vrfName).Protocol(oc.PolicyTypes_INSTALL_PROTOCOL_TYPE_BGP, "BGP").Bgp().Neighbor(atePort2.IPv4).AfiSafi(oc.BgpTypes_AFI_SAFI_TYPE_IPV4_UNICAST).ApplyPolicy()

gnmi.BatchReplace(batch, path.Config(), policy)

Expand Down Expand Up @@ -316,7 +316,7 @@ func appendDrainPolicyToExport(t *testing.T, dut *ondatra.DUTDevice) {
t.Helper()
nbrPath := gnmi.OC().NetworkInstance(vrfName).Protocol(oc.PolicyTypes_INSTALL_PROTOCOL_TYPE_BGP, "BGP").Bgp().Neighbor(atePort2.IPv4).AfiSafi(oc.BgpTypes_AFI_SAFI_TYPE_IPV4_UNICAST).ApplyPolicy()
exportPolicies := []string{drainPolicy, bgpExportPol}
gnmi.Update(t, dut, nbrPath.ExportPolicy().Config(), exportPolicies)
gnmi.Replace(t, dut, nbrPath.ExportPolicy().Config(), exportPolicies)
}

// removeDrainPolicyFromExport removes the drain policy from the BGP export chain.
Expand Down Expand Up @@ -507,11 +507,13 @@ func validateRoutingPolicyV4(t *testing.T, dut *ondatra.DUTDevice, ate *ondatra.
bgpPrefixes := gnmi.GetAll[*otgtelemetry.BgpPeer_UnicastIpv4Prefix](t, ate.OTG(), gnmi.OTG().BgpPeer("atePort2.BGP4.peer").UnicastIpv4PrefixAny().State())
found := false
var errMsg string
parts := strings.Split(routePrefix, "/")
prefixAddr := parts[0]
prefixLen, _ := strconv.Atoi(parts[1])

for _, bgpPrefix := range bgpPrefixes {
t.Logf("Received prefix %s/%d", bgpPrefix.GetAddress(), bgpPrefix.GetPrefixLength())

if bgpPrefix.Address != nil && bgpPrefix.GetAddress() == v4RoutePrefix && bgpPrefix.PrefixLength != nil && bgpPrefix.GetPrefixLength() == v4RoutePrefixLen {
if bgpPrefix.Address != nil && bgpPrefix.GetAddress() == prefixAddr && bgpPrefix.PrefixLength != nil && bgpPrefix.GetPrefixLength() == uint32(prefixLen) {

found = true

Expand Down Expand Up @@ -548,7 +550,7 @@ func validateRoutingPolicyV4(t *testing.T, dut *ondatra.DUTDevice, ate *ondatra.
}

if !found {
msg := fmt.Sprintf("prefix %s/%d not received on OTG", v4RoutePrefix, v4RoutePrefixLen)
msg := fmt.Sprintf("prefix %s not received on OTG", routePrefix)
errMsg += msg
}

Expand Down
Loading