Skip to content

Modifications to isisRT2.18#5473

Open
divyarema wants to merge 1 commit into
openconfig:mainfrom
divyarema:isisRT2.18
Open

Modifications to isisRT2.18#5473
divyarema wants to merge 1 commit into
openconfig:mainfrom
divyarema:isisRT2.18

Conversation

@divyarema
Copy link
Copy Markdown
Contributor

Added deviation interface_ref_interface_id_format

@divyarema divyarema requested a review from a team as a code owner May 15, 2026 07:24
@google-cla
Copy link
Copy Markdown

google-cla Bot commented May 15, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the test metadata for the ISIS scale multi-adjacency test suite. By enabling the interface_ref_interface_id_format deviation, the test configuration is aligned with current requirements for handling interface references, ensuring consistent test execution.

Highlights

  • Configuration Update: Added the interface_ref_interface_id_format deviation to the ISIS scale multi-adjacency test metadata.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot
Copy link
Copy Markdown

Pull Request Functional Test Report for #5473 / 30176a7

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
RT-2.18: IS-IS Multi-adjacencies scale test
Cisco 8000E status
RT-2.18: IS-IS Multi-adjacencies scale test
Cisco XRd status
RT-2.18: IS-IS Multi-adjacencies scale test
Juniper ncPTX status
RT-2.18: IS-IS Multi-adjacencies scale test
Nokia SR Linux status
RT-2.18: IS-IS Multi-adjacencies scale test
Openconfig Lemming status
RT-2.18: IS-IS Multi-adjacencies scale test

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
RT-2.18: IS-IS Multi-adjacencies scale test
Cisco 8808 status
RT-2.18: IS-IS Multi-adjacencies scale test
Juniper PTX10008 status
RT-2.18: IS-IS Multi-adjacencies scale test
Nokia 7250 IXR-10e status
RT-2.18: IS-IS Multi-adjacencies scale test

Help

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the metadata.textproto file for the ISIS scale multi-adjacency test to enable the interface_ref_interface_id_format deviation. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants