Adding ACCTZ-10.1: gNSI.acctz.v1 (Accounting) Test Accounting Authentication Error - Multi-transaction Test

[keysightgems]

Readme Location: https://github.com/openconfig/featureprofiles/blob/main/feature/gnsi/acctz/tests/AccountingAuthenErrorMulti/README.md

Attached logs here: https://partnerissuetracker.corp.google.com/u/2/issues/513474337

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new test case for the gNSI Accounting (acctz) feature, specifically focusing on verifying authentication error handling across multiple transactions. The test ensures that the device correctly generates and records accounting events when authentication fails due to backend unavailability, while also providing necessary metadata configurations to support cross-platform testing.

Highlights

• New Test Implementation: Added a new test file accounting_authen_error_multi_test.go to validate gNSI accounting behavior during multi-transaction authentication errors.
• Metadata Updates: Updated metadata.textproto to include platform-specific deviations for Arista and Cisco devices.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5475 / acf51ea

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		ACCTZ-10.1: gNSI.acctz.v1 (Accounting) Test Accounting Authentication Error - Multi-transaction
Cisco 8000E		ACCTZ-10.1: gNSI.acctz.v1 (Accounting) Test Accounting Authentication Error - Multi-transaction
Cisco XRd		ACCTZ-10.1: gNSI.acctz.v1 (Accounting) Test Accounting Authentication Error - Multi-transaction
Juniper ncPTX		ACCTZ-10.1: gNSI.acctz.v1 (Accounting) Test Accounting Authentication Error - Multi-transaction
Nokia SR Linux		ACCTZ-10.1: gNSI.acctz.v1 (Accounting) Test Accounting Authentication Error - Multi-transaction
Openconfig Lemming		ACCTZ-10.1: gNSI.acctz.v1 (Accounting) Test Accounting Authentication Error - Multi-transaction

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		ACCTZ-10.1: gNSI.acctz.v1 (Accounting) Test Accounting Authentication Error - Multi-transaction
Cisco 8808		ACCTZ-10.1: gNSI.acctz.v1 (Accounting) Test Accounting Authentication Error - Multi-transaction
Juniper PTX10008		ACCTZ-10.1: gNSI.acctz.v1 (Accounting) Test Accounting Authentication Error - Multi-transaction
Nokia 7250 IXR-10e		ACCTZ-10.1: gNSI.acctz.v1 (Accounting) Test Accounting Authentication Error - Multi-transaction

Help

[gemini-code-assist]

Code Review

This pull request introduces a new test for gNSI accounting (acctz) to verify authentication error records during multi-transaction scenarios where the TACACS backend is unavailable. It also adds platform-specific deviations for Arista and Cisco in the metadata. Feedback focuses on addressing resource leaks, including a potential TCP connection leak and a goroutine leak in the record collection logic. Additionally, improvements were suggested for gRPC stream error handling, specifically regarding io.EOF, and the use of t.Fatalf for terminal test failures.