Certz2.1 updated the timeout and changed the error response as fatal

[priyacj]

Prior commit : #3313 (ref)

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the reliability of gNSI and P4Rt testing by adjusting wait times for large-scale certificate operations and enforcing stricter failure conditions during capability validation. These changes ensure that tests do not proceed in an invalid state when critical connection errors occur.

Highlights

• Increased propagation delay: Added a 180-second wait period for large-scale certificate propagation in the CertzRotate function when the scale flag is enabled.
• Error handling improvements: Updated error handling in gNMI and P4Rt capability validation to use t.Fatalf instead of t.Errorf, ensuring tests fail immediately upon connection errors.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5489 / c1b4f4f

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		CERTZ-2: Server Certificate
Cisco 8000E		CERTZ-2: Server Certificate
Cisco XRd		CERTZ-2: Server Certificate
Juniper ncPTX		CERTZ-2: Server Certificate
Nokia SR Linux		CERTZ-2: Server Certificate
Openconfig Lemming		CERTZ-2: Server Certificate

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		CERTZ-2: Server Certificate
Cisco 8808		CERTZ-2: Server Certificate
Juniper PTX10008		CERTZ-2: Server Certificate
Nokia 7250 IXR-10e		CERTZ-2: Server Certificate

Help

[gemini-code-assist]

Code Review

This pull request adds a conditional 180-second sleep for large-scale certificate propagation when the scale flag is set and updates capability request validations for gNMI and P4Runtime to use t.Fatalf for immediate failure. I have no feedback to provide as no review comments were included in this assessment.