Reuse sleep deviation in packet link qual TestListDelete

[cmcdona2]

Currently, the deviations.LinkQualWaitAfterDeleteRequired 10 second sleep is at the end of TestListDelete. To support an asynchronous Delete gRPC, we can reposition this sleep between where we issue deletes and where we check deleted results.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request optimizes the TestListDelete test flow to better accommodate asynchronous gRPC delete operations. By shifting the required wait period to occur between the deletion phase and the verification phase, the test ensures that the system has sufficient time to process state changes before validation, improving reliability in environments where this specific deviation is required.

Highlights

• Refactored Test Execution Flow: Repositioned the mandatory 10-second sleep deviation to occur after all delete operations are issued but before verification begins.
• Improved Test Robustness: Introduced a map to track clients that successfully issued deletes, ensuring verification logic only runs against relevant targets.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5494 / af363ba

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		gNOI-2.1: Packet-based Link Qualification on 100G and 400G links
Cisco 8000E		gNOI-2.1: Packet-based Link Qualification on 100G and 400G links
Cisco XRd		gNOI-2.1: Packet-based Link Qualification on 100G and 400G links
Juniper ncPTX		gNOI-2.1: Packet-based Link Qualification on 100G and 400G links
Nokia SR Linux		gNOI-2.1: Packet-based Link Qualification on 100G and 400G links
Openconfig Lemming		gNOI-2.1: Packet-based Link Qualification on 100G and 400G links

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		gNOI-2.1: Packet-based Link Qualification on 100G and 400G links
Cisco 8808		gNOI-2.1: Packet-based Link Qualification on 100G and 400G links
Juniper PTX10008		gNOI-2.1: Packet-based Link Qualification on 100G and 400G links
Nokia 7250 IXR-10e		gNOI-2.1: Packet-based Link Qualification on 100G and 400G links

Help

[gemini-code-assist]

Code Review

This pull request updates the TestListDelete function to track clients that issued delete requests and adjusts the timing of the post-deletion sleep. Review feedback suggests using a slice instead of a map to maintain deterministic iteration order during verification and recommends conditionally executing the sleep only when deletions have occurred.