Add watch for ACL counter updates

[ijernoiu]

Add watch for ACL counter matched packets instead of one-time check

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the ACL counter verification logic in the OTG tests. By switching from a single snapshot check to a continuous watch, the test can now more reliably wait for the expected number of matched packets to be registered, reducing flakiness in environments where counter updates might be delayed.

Highlights

• Improved ACL Counter Verification: Replaced the one-time ACL counter check with a robust watch mechanism that polls for the expected packet delta, increasing test reliability.
• Increased Timeout: Extended the aclCounterTimeout from 5 seconds to 10 seconds to accommodate potential latency in counter updates.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5500 / 6a4b399

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		ACL-1.2: ACL Update (Make-before-break)
Cisco 8000E		ACL-1.2: ACL Update (Make-before-break)
Cisco XRd		ACL-1.2: ACL Update (Make-before-break)
Juniper ncPTX		ACL-1.2: ACL Update (Make-before-break)
Nokia SR Linux		ACL-1.2: ACL Update (Make-before-break)
Openconfig Lemming		ACL-1.2: ACL Update (Make-before-break)

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		ACL-1.2: ACL Update (Make-before-break)
Cisco 8808		ACL-1.2: ACL Update (Make-before-break)
Juniper PTX10008		ACL-1.2: ACL Update (Make-before-break)
Nokia 7250 IXR-10e		ACL-1.2: ACL Update (Make-before-break)

Help

[gemini-code-assist]

Code Review

This pull request increases the ACL counter timeout and refactors the verifyACLCounters function to use a single gnmi.Watch call for monitoring packet count deltas. The review feedback identifies several robustness issues in the new implementation, including the failure to check the return value of the Await call, potential uint64 wrap-around errors if the watch times out, and incorrect initialization of the missingCounter flag. A comprehensive code suggestion was provided to address these issues and add defensive checks for counter resets.

[ijernoiu]

/gemini review

[gemini-code-assist]

Code Review

This pull request increases the aclCounterTimeout from 5 to 10 seconds and refactors the verifyACLCounters function in the ACL update test. The refactoring consolidates the ACL entry existence check and the packet counter validation into a single gnmi.Watch operation that waits for the expected packet delta to be reached. I have no feedback to provide.